Disk system add-ons need to be translated (which will display in DriveSetup)

[blutigerWilliam]

Some Strings, especially the file system names, in DriveSetup remain untranslated in the german localization of haiku.

I use hrev40501 GCC4hybrid.

[siarzhuk]

Please check revisions after hrev40734. Frankly speaking it is not clear what is your problem. Please explain - which string should be translated. Thanks.

[diver]

This ticket is about "* File System" labels, see here.

[blutigerWilliam]

Diver is right, that is exactly, what i mean.

Regards

[korli]

przemub,

could you please post a screenshot with your patch applied?

Thanks!

[przemub]

Replying to korli:

przemub,

could you please post a screenshot with your patch applied?

Thanks!

Before taking this screenshot I've added translations of "Be File System" and "Intel Partition Map" string to Polish catkey file.

[mmadia]

Is this patch OK to commit?

[stippi]

To me, the patch looks very strange. How can it work? I thought B_TRANSLATE is a macro and everything is extracted by a tool (collect_cat_keys?). But "diskSystem.prettyName()" will only expand to a readable string when the program is actually running, no? What string ended up in the locale file? Am I missing something?

[stippi]

Ok, I think I understand. The patch would actually work if all file systems would be added to the catalogs, but this is wrong still, since the translations are added in the wrong catalogs. The disk system add-ons themselves need to be translated, not DriveSetup.

[siarzhuk]

Replying to stippi:

Ok, I think I understand. The patch would actually work if all file systems would be added to the catalogs, but this is wrong still, since the translations are added in the wrong catalogs.

AFAIR the list of B_TRANSLATE_MARK definitions for known file system names can be used to help harvest ones for catkeys at the build time. Filtering varaible with file system name throught B_TRANSLE at run-time will do the final localiation work.

The disk system add-ons themselves need to be translated, not DriveSetup.

In case those names are just cosmetic and do not used for any kind of identification. AFAIR most of post-localization regressions were caused by such straightforward technique.