Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#7461 closed bug (fixed)

[RTF-Translator] rename to "RTFTranslator"

Reported by: diver Owned by: axeld
Priority: normal Milestone: R1
Component: Add-Ons/Translators/RTF Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All


RTF-Translator is the only translator with dash in it's name.

Change History (9)

comment:1 Changed 8 years ago by axeld

I would rather like to drop the "Translator" part altogether, at least I see no good reason to have it there.

comment:2 Changed 8 years ago by diver

I second that.

comment:3 Changed 7 years ago by humdinger

Thirded. :)
So, can we just rename it all in their jam files now? Doing that before alpha4 is released seems to be a good opportunity.

BTW, the same file name cropping could be done with what's inside /boot/system/add-ons/media/. Here every file ends in ".media_addon"

comment:4 Changed 7 years ago by leavengood

Even though it seems redundant I think keeping Translator and media_addon a part of the name still makes sense to help identify what they are. I think relying on the directory to help identify files is a bad idea.

But I'm fine with taking the dash out of the RTFTranslator :)

comment:5 Changed 7 years ago by humdinger

I'm not particularly keen on renaming these files. They are just exceptionally named compared to most of the other files there. It's just not very consistent: you have *.accelerant and *.media-addon, app_server and mail_daemon, but *Translator and plain names like bfs under disk_systems and Screen Savers. There are folders starting with a capital and most all lower case. Some with an underscore, only "Screen Savers" with a space...
The settings files under ~/config/settings are equally mixed.

Do we want to make all those consistend one day (if yes, better sooner than later) or are these unimportant details?

comment:6 Changed 7 years ago by leavengood

Fixed in hrev44521.

I'm definitely one for making things consistent. I'm not sure exactly what scheme we would want though. My best comparison is with a Ruby on Rails project, which has controllers and helpers which always have Controller or Helper at the end of the name, yet models are always just the name of the thing, like User or Video. I think part of that might just be that they feel the model is the core class and the others are classes which help out, and everything couldn't be named the same (User, User and User.) Though things aren't quite the same with these things in Haiku.

If someone can come up with a sane renaming of these things I would be up for fixing it. In fact we might just want to clean this all up as part of package management.

comment:7 Changed 7 years ago by leavengood

Resolution: fixed
Status: newclosed

comment:8 Changed 7 years ago by axeld

Haiku does generally not require the use of suffixes, so I don't see the point in including the file kind information in the name of the file. We do not have an .exe or .app for our binaries, why should we have *Translator, or *.media_addon?

If you remove "ls" from /bin, the file pretty much loses its purpose, exactly like when you move a translator out of its directory, or "ntfs" out of the file system folder. Why handle those cases differently? Having those suffixes is just redundant, especially because all files need to be in a specific directory to have any meaning.

I would prefer an attribute based identification instead of any kind of suffix. Also, the system should try hard to keep duplicate names at a minimum (so that "intel" only ever refers to the partitioning system, whereas other Intel specific things get proper names, like "intel_gart", or "intel_extreme").

comment:9 Changed 7 years ago by leavengood

The name duplication issue is why I'm personally hesitant to rename the translators. Are names like PNG, JPEG, RTF, ICO, etc unique enough? Maybe if they are always caps. I think removing the media_addon suffix would be OK, though I'm sure the media server looks for that in the name.

Note: See TracTickets for help on using tickets.