[CDPlayer] throws errors in syslog

[diver]

This is hrev41270, gcc4 hybrid.

After running CDPlayer syslog fills with this error:

KERN: ata 1 error: command failed, error bit is set. status 0x41, error 0x50
KERN: check_sense: Illegal request

[mmlr]

The reason for this is that CDPlayer issues a read TOC (table of contents) command to the CD drives that will return with "Illegal request" as long as there is no CD in the drive (or one without a TOC). To check for a disc insertion CDPlayer issues this over and over every few seconds, hence the syslog fill up. The output of the ATA stack is valid though and issuing the command is not wrong per se. The error output basically translates to "no valid TOC found" in this case. It could theoretically be disabled at the ATA level, but since that might hide the output for other, actual error cases I'd favor not doing so.

I'm not sure CDPlayer has any other way to check for CD presence, but if it has it should be changed to use it. On the other hand, the CDDA filesystem really makes the CDPlayer superfluous anyway, so the CDPlayer could just be dumped completely.

[waddlesplash]

CDPlayer has now been "dumped completely".