Mail preferences only partially localized

[taos]

Using hrev41280 (gcc2hybrid).

Mail preflet is only partially localized. (For screenshots, I switched to Russian (cyrillic) to emphasize the missing parts.)

• "Settings" tab is fully localized (not shown here).

• "Accounts" tab is partially localized:

"· Incoming", "· Outgoing", and "· E-mail filters" are prepared for translation in ConfigWindow.cpp. These strings appear on ​HTA and are also included in the respective catkeys. However, the translation is not used (maybe because of the bullet?).

• "Incoming" settings are not localized at all.

• "Outgoing" settings are not localized.

• "E-mail filters" settings are not localized.

A number of these strings is already prepared for translation by using B_TRANSLATE() in source code. AutoConfigView.cpp for example used to provide strings with context "E-Mail" at some point in the past (as evident in obsolete strings on ​HTA), but is currently missing "#include Locale.h" and an entry in the corresponding jamfile. FilterConfigView.cpp provides strings with context "Config Views" that were translated on HTA, but is also missing from jamfile. So, already translated strings never make it to the corresponding catkeys.

[taos]

Partially localized "Accounts" tab.

[taos]

"Incoming" settings missing localization.

[taos]

"Outgoing" settings missing localization.

[taos]

"E-mail filters" settings missing localization.

[pulkomandy]

Part of these are actually in the IMAP and SMTP add-ons. They need to be localized in different catalogs, because they don't have the preflet mime signature but another one.

[taos]

Now, that the mail_daemon add-ons are localized (see Ticket #7689, hrev42293) the mail preflet should be fully localized, too. Unfortunately, with hrev42328 (compiled as @nightly-raw) the localization is still missing. The respective catalogs are there but are not used. Mail preferences as well as Mail menu in Deskbar are still not translated when switching languages in locale preflet. Is there anything else that must be changed before the catalogs are used?

[czeidler]

shame on me but I'm quite unfamiliar with the local kit, pulkomandy probably knows more. You could take a look at the powerstatus app as far as I remember there have been similar problems... The PowerStatusView can live in the deskbar and in the app and there has been some problems.

[taos]

Do we need *.rdef files for the add-ons? Seems adding those to disk_systems add-ons helped to fully localize DriveSetup (#5594).

[taos]

Patch ("rdef_and_jamfiles.patch") added. Catalogs should now be used (at least, it works on my system - and we obviously need to make mail preferences aware of layout). I don't know what new .rdef files should look like so I used BFSAddOn.rdef as inspiration.

[taos]

Unfortunately, I introduced x-vnd.Haiku-mail_daemon for the catalogs when localizing mail_daemon. However, I didn't notice that there already was "application/x-vnd.Be-POST" in mail_daemon.rdef. The patch changes the catalog entry to x-vnd.Be-POST. I'm afraid that mail_daemon might have to be translated again on HTA, consequently.

[taos]

Adds .rdef files (+ entries in the respective Jamfiles).

[czeidler]

thanks!

- B_TRANSLATE("Fetching IMAP folders, have patience..."));
+ B_TRANSLATE("Fetching IMAP folders, have patience" B_UTF8_ELLIPSIS));

is this really a case for B_UTF8_ELLIPSIS?

x-vnd.Haiku-mail_daemon sounds better to me is there any backward compatibility issue? (outside of the haiku source?)

[axeld]

Other mail applications could interact with the mail_daemon, and also want to start it when it's not running yet. I think there were examples of such applications out there, or else we would have changed the signature already.

[taos]

I've added another patch ("Mail_localization.patch") to localize spam filter and to add a few missing strings for mail_daemon (+ add-ons) and mail preflet. As HTA removes space characters from beginning and end of a translated string (so that they can't be used by haiku) I tried to get rid of them (inspiration from mt's patch for #7689).

[pulkomandy]

Please avoid hardcoding spaces like this. Some languages (eg. Chinese) don't use spaces at all, for them it make the whole thing look wrong without any way to fix it.

error_msg << B_TRANSLATE("Error while authenticating user") << " " << uid;

This makes it impossible :

• To have no space before the uid in languages where it isn't needed
• To do the right thing when a language needs something such as "Error while authenticating %uid% user".

Please use BString ReplaceFirst API instead for building strings from separate variables.

[taos]

I'll add an updated patch in a few minutes to remove the hardcoded spaces. Could you please have a look at it (especially pop3.cpp and smtp.cpp) since I'm new to this?

[taos]

Adds localization for spam filter, removes space characters from translation strings (updated).

[pulkomandy]

It's fine now. Thanks !

[czeidler]

thanks! next time please do a svn up first, there have been some clashes...

[taos]

Replying to czeidler:

thanks! next time please do a svn up first, there have been some clashes...

Sorry, I trusted my script (1. svn update, 2. svn diff) to take care of this. Next time, I'll have a closer look at the reference revision. Oh, was the problem that I had two different reference revisions (hrev42339 and hrev42341) in the patch file?

Thanks for applying the patch despite the clashes!

[czeidler]

oh don't know, actually just patch complained and when I checked the files everything was more or less fine...