Opened 14 years ago

Closed 14 years ago

#7507 closed enhancement (fixed)

Do not overwrite the disk ID

Reported by: starsseed Owned by: bonefish
Priority: normal Milestone: R1
Component: Partitioning Systems/Intel Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

Do not overwrite the disk ID in the MBR since Linux, Windows (and some BIOSes) may need it.

Attachments (1)

PreserveMBRdiskID.patch​ (1.7 KB ) - added by starsseed 14 years ago.
coding style fixes

Download all attachments as: .zip

Change History (4)

comment:1 by starsseed, 14 years ago

patch: 0 → 1

comment:2 by bonefish, 14 years ago

Looks OK save for the introduction of coding style issues. BTW, there are STATIC_ASSERT() macros defined in the kernel private <debug.h> and in the public <Debug.h>.

by starsseed, 14 years ago

Attachment: PreserveMBRdiskID.patch​ added

coding style fixes

comment:3 by bonefish, 14 years ago

Resolution: → fixed
Status: new → closed

Applied in hrev41565 with the following coding style fixes:

  • debug.h is private kernel header and thus does not belong in the public C headers section.
  • Joined the status_t error declaration with its initialization.
  • Space after "//".
  • Spaces around non-unary operators.
Note: See TracTickets for help on using tickets.