Opened 8 years ago

Closed 8 years ago

#7548 closed bug (fixed)

Patch to make vertical BSliders work

Reported by: Pete Owned by: stippi
Priority: normal Milestone: R1
Component: Kits/Interface Kit Version: R1/alpha2
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

I guess I'm the first person to have actually needed vertical sliders, but found that they worked very badly in my ported BeOS app. (I see Stippi noted this three years ago, but apparently got sidetracked...)

The attached patch fixes the observed problems:

Height of sliders was never more than 100 pixels

Slider bar fill colouring didn't work

The triangle thumb (in ControlLook) wasn't rotated

(I notice that Haiku triangle thumbs are on the right, while BeOS had them on the left. I vaguely find the Haiku convention more natural, so I didn't mess with that.)

Attachments (1)

vslider.diff (3.8 KB) - added by Pete 8 years ago.
Patch for Slider.cpp and ControlLook.cpp

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Pete

Attachment: vslider.diff added

Patch for Slider.cpp and ControlLook.cpp

comment:1 Changed 8 years ago by Pete

Has a Patch: set

comment:2 Changed 8 years ago by stippi

Owner: changed from axeld to stippi
Status: newin-progress

Patch looks fine, thank you!

comment:3 Changed 8 years ago by stippi

Applied with coding style corrections in hrev41881 (you probably get merge conflicts when you update, please have a look at what I changed). Thanks for your work, greatly appreciated!

comment:4 Changed 8 years ago by stippi

Resolution: fixed
Status: in-progressclosed
Note: See TracTickets for help on using tickets.