[Terminal] add cp1251/koi8-r encodings

[diver]

Currently looking into this because of special request from Diver.

[axeld]

The best way to go about this would be to enable those encodings in libtextencoding.so - I would think that libiconv (which is our backend there) should already contain support for it.

[siarzhuk]

There are no problems with the koi-8r <-> utf-8 conversion - it works out of the box now - just after adding corresponding menu entries. I can say it works well, until you try to do something. Looks like any 8-bit encoding in our Terminal aren't functional at the moment. And that is my current headache. But on the bright side - looks like I'll kill some other tickets related to ANSI parsing. ;-)

[zooey]

At least to some extent the problems Terminal has with 8-bit encodings are related to our broken implementation of the multibyte-functions (mbrtowc() and friends). During BeGeistert, I worked on that and got it basically working.

The reason for me not having applied those changes is that some ICU-related internal resource handling is still missing and the fact that those changes require a complete rebuild of the buildtools.

I'm going to commit the changes as soon as I have time for it, which is going to be after the switch to Git has been completed (i.e. at the beginning of next week).

[siarzhuk]

Replying to zooey:

I'm going to commit the changes as soon as I have time for it, which is going to be after the switch to Git has been completed (i.e. at the beginning of next week).

Nice to hear that we will have functional multibyte support soon! ;-) On my side the issues are in Terminal's TermParse.cpp code and related on internal handling of ANSI control sequences - and are not related on system convertion support.

[siarzhuk]

Fixed in hrev43252.