Fading in toolbar in full screen mode kills toolbar in window mode

[humdinger]

This is hrev42282.

Do this:

• Open an image in ShowImage
• Make sure the toolbar is showing
• Enter full screen mode with ALT+ENTER
• Move the mouse to fade in the toolbar
• Wait until the toolbar disappears again and switch back to window mode with ALT+ENTER (if you switch while the toolbar is still showing, everything works as expected)

-> Now in window mode, the toolbar is gone and instead the 32(?) lines of the image are repeated:

[humdinger]

Toolbar destroyed after full screen mode

[leavengood]

Fixed in hrev42306.

[diver]

I can still reproduce it in hrev44434 with the following steps:

• Open an image in ShowImage
• Enter full screen mode with double click
• Make sure the toolbar is showing
• Move the mouse to fade in the toolbar
• When the toolbar starts disappearing switch back to window mode with double click

[leavengood]

With some effort (including making VirtualBox really slow) I was able to reproduce diver's latest version of this, but it is pretty hard to do, so I may put this bug in my low priority list. Eventually some sort of class could be added to manage the state and animating of the toolbar button, and maybe that could help avoid these issues (which really are just a form of race condition.)

[diver]

I can reproduce it easily on real hardware.

[diver]

The other way to reproduce it is just to open this image in window mode and hold Atl+T for several seconds.

[Janus]

Double post same patch. Sorry.

[Janus]

Still a small race condition in transition from fullscreen to window (toolbar hidden). This is very hard to fix.

[axeld]

Applied in hrev45249, thanks a lot! Not sure if it's worth to keep this bug open -- opinions?

[diver]

Can't reproduce anymore, closing. Thanks!