[Patch] Deskbar Truncate String Code Cleanup

[jscipione]

I re-factored the Deskbar truncate label code (The code that truncates a string with an ellipses like Activi...onitor when space gets tight in horizontal mode) to use a a single BString instead of a const char* and a char* that gets malloc'ed and free'd. The code does exactly the same thing but is just a little cleaner.

[jscipione]

A patch that replaces a malloc and free of a char* and a const char* with a single BString.

[jscipione]

There is no reason to check if the label is NULL after truncating since I am using a BString which will not return NULL for a truncated string.

[Charlie_X]

Do you have tests for this?

[jscipione]

Replying to Charlie_X:

Do you have tests for this?

There is a test for BView->TruncateString() in src/tests/kits/interface/TruncateString.cpp

[pulkomandy]

This is not correct :

• Creating a BString object and copying the full label to it costs more than mallocing a string. So your change makes the code slower.
• TruncateLabel does not do the same as TruncateString. It is dedicated to menus and may do complex stuff such as ensuring the result is not the same as the truncated label from another menu item in the same menu. (even if that may not be implemented yet).

While the TruncateLabel function is a bit unsafe (no control on the buffer size), we have no way to fix it without breaking binary compatibility. So this will have to wait till R2...