Opened 7 years ago

Last modified 2 years ago

#8116 assigned enhancement

Add a "Select {current folder}" button to filepanels

Reported by: humdinger Owned by: nobody
Priority: normal Milestone: R1
Component: Kits/Storage Kit Version: R1/Development
Keywords: BFilePanel Cc:
Blocked By: Blocking: #9120
Has a Patch: no Platform: All

Description

This is hrev4902.

Expander has a custom file panel with a button "Select {current folder}":

Expander's file panel sporting a "Select {this folder}".

This saves you from having to navgate to a folders parent, just to select that folder.

Is is possible to backwards-compatibly have this button for every BFilePanel that has the node_flavor B_DIRECTORY_NODE?

Attachments (1)

Expander_panel.png (11.6 KB) - added by humdinger 7 years ago.
Expander's file panel sporting a "Select {this folder}".

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by humdinger

Attachment: Expander_panel.png added

Expander's file panel sporting a "Select {this folder}".

comment:1 Changed 6 years ago by humdinger

Is this in the scope of a GCI task?

comment:2 Changed 6 years ago by Giova84

Any news about this ticket? Could be easily implemented? That would be definitely an useful enhancement! :-)

comment:3 Changed 4 years ago by pulkomandy

Unfortunately, not the easy way. Some applications (for example Expander) customize the filepanel to add such a button. If we put one there by default, such apps would then have two buttons. Maybe we can have a separate flag or method to enable this button instead, so existing apps aren't affected. But then we need to update all apps to make use of the feature, which isn't so great.

comment:4 Changed 4 years ago by pulkomandy

Blocking: 9120 added

comment:5 Changed 2 years ago by axeld

Owner: changed from axeld to nobody
Status: newassigned

comment:6 Changed 2 years ago by humdinger

As I read owenca's Filer issue #20: How about not adding another button, but just keeping the file panel's "Open" button active if there's no folder selected? Pressing open would then choose the current folder. Not completely obvious, but still better than the hoops we have to jump at the moment: Going up to the parent folder to choose our folder.

Oh, oh, how about re-labeling the "Open" button to "Open current folder" if no folder is selected, "Open {folder name}" if one folder is selected and "Open {number of selected folders} folders" if more than one folder is selected.

comment:7 Changed 2 years ago by axeld

That wouldn't really solve the issue of applications customizing the panel, though. We really have only two choices here AFAICT:

  1. Add a flag that adds the button or changes how "open" works (I haven't made up my mind about that yet, although I often wondered why "open" would just open the folder, and not close the panel).
  2. Detect R5 software, and let them suffer, and document Haiku's different behavior (and fixing all apps in tree).

Both solutions won't provide a consistent user experience, though, although 2.) is slightly better in this regard, as the problem will fade away with time :-)

Note: See TracTickets for help on using tickets.