Opened 8 years ago

Last modified 3 years ago

#8237 assigned bug

CR2 image will not display properly

Reported by: SeanCollins Owned by: nobody
Priority: normal Milestone: R1
Component: Add-Ons/Translators/RAW Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description (last modified by diver)

gcc2h hrev43447 nightly

attaching screen shot and link to file.

Attachments (1)

screenshot1.png (54.2 KB ) - added by SeanCollins 8 years ago.

Download all attachments as: .zip

Change History (7)

by SeanCollins, 8 years ago

Attachment: screenshot1.png added

comment:2 by diver, 8 years ago

Component: Applications/ShowImageAdd-Ons/Translators/RAW
Description: modified (diff)
Owner: changed from leavengood to axeld
Version: R1/alpha3R1/Development

comment:3 by pulkomandy, 5 years ago

The current version of dcraw converts this image to a ppm which ShowImage can open. Unfortunately dcraw is still distributed as a monolithic .c file so we need to analyze the changes and backport them to our cleaned up C++ version. dcraw is versionned using RCS, so extracting the changes from there may not be as easy as usual.

comment:4 by pulkomandy, 5 years ago

We could make the translator use http://www.libraw.org. I have confirmed that older versions of dcraw have the same problem decoding this image, various issues were fixed and the image looks correct starting from dcraw 9.08. However merging the changes back to our forked and rewritten version is error-prone and time consuming.

Rewriting the translator to use libraw instead should fix the problem. Libraw is based on the same code, but kept up to date with current versions.

comment:5 by axeld, 3 years ago

Unfortunately, libraw needs gcc 4+ to compile, so a solution based on it would not work with the default system. One of the few cases where binary compatibility hurts.

Of course, we could provide different implementations depending on the target platform, so that x86 and x86-64 would not be affected (same for ffmpeg).

comment:6 by axeld, 3 years ago

Owner: changed from axeld to nobody
Status: newassigned
Note: See TracTickets for help on using tickets.