Opened 7 years ago

Last modified 3 years ago

#8365 in-progress enhancement

Workspaces size doesn't update as you change the options (easy)

Reported by: jstressman Owned by: leavengood
Priority: normal Milestone: R1
Component: Applications/Workspaces Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

If you change the number of columns and rows for Workspaces, it doesn't update the size of the Workspaces window to correctly fit the workspaces in there in relation to their aspect ratio. So you end up with a bunch of squished workspaces until you actually click on the Workspaces window to resize it... then it suddenly snaps to the proper dimensions.

Shouldn't this update as you make the settings changes? Perhaps not exceeding the starting width x height dimensions so as not to end up outside the current desktop borders?

Attachments (3)

workspaces7.png (29.7 KB) - added by jstressman 7 years ago.
workspaceszoom1.patch (4.2 KB) - added by devine 7 years ago.
Updates the size (by calling Zoom()) when the workspace layout is updated. Depends on patch in #8188
workspaceszoom1.2.patch (4.2 KB) - added by devine 7 years ago.
Updates the size (by calling Zoom()) when the workspace layout is updated. Depends on patch in #8188

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by jstressman

Attachment: workspaces7.png added

comment:1 Changed 7 years ago by jstressman

This is in hrev43809 by the way.

comment:2 Changed 7 years ago by axeld

This could certainly be done, best based on the current aspect ratio. It could simply move the window to prevent it from leaving the screen.

comment:3 Changed 7 years ago by axeld

Summary: Workspaces size doesn't update as you change the optionsWorkspaces size doesn't update as you change the options (easy)

comment:4 Changed 7 years ago by devine

I will a attach a patch for this. It is depended on the changes made in the patch #8188 though.

Changed 7 years ago by devine

Attachment: workspaceszoom1.patch added

Updates the size (by calling Zoom()) when the workspace layout is updated. Depends on patch in #8188

comment:5 Changed 7 years ago by devine

Has a Patch: set

Changed 7 years ago by devine

Attachment: workspaceszoom1.2.patch added

Updates the size (by calling Zoom()) when the workspace layout is updated. Depends on patch in #8188

comment:6 Changed 7 years ago by leavengood

Owner: changed from axeld to leavengood
Status: newin-progress

Taking ownership.

comment:7 Changed 3 years ago by pulkomandy

Has a Patch: unset

comment:8 Changed 3 years ago by pulkomandy

Several comments on the patch (which proabably does not apply anymore to the current codebase).

It does not feel right to have the notification sent from the screen preferences. There could be other places able to control the workspace count. Instead, the message should be sent from app_server when the workspaces are actually created or deleted.

Handling of the window position in this case will be tricky.

  • If the window was at the screen edge for use with auto-raise, it should snap to said edge and change its size so the workspaces size in the preview stays the same.
  • If it is not at any particular screen edge, Zoom will move it there if the auto-raise feature is enabled. Otherwise, it should only make sure that the window fits into the screen.
Note: See TracTickets for help on using tickets.