Opened 8 years ago

Closed 4 years ago

#8376 closed bug (fixed)

Audio CD CDDB Tracker KDL GCC4hybrid

Reported by: shaka Owned by: bga
Priority: normal Milestone: R1
Component: File Systems/cdda Version: R1/Development
Keywords: Cc: degea@…
Blocked By: Blocking:
Has a Patch: no Platform: x86

Description

There seems to be a Tracker bug related to audio cd's. While importing (ironically enough, the audio book "Steve Jobs") I noticed that sometimes the desktop icon reflected the cd title properly, other times not, just "Audio CD", yet when browsing with Tracker, the name was the correct CDDB title. But just opening the CD to view files, then closing the Tracker window would bring me to KDL. This happened both when the name was correct and when not correct.

Attachments (1)

screenshot1.jpeg (166.0 KB ) - added by shaka 8 years ago.
Screenshot of CD showing different name than Tracker

Download all attachments as: .zip

Change History (10)

comment:1 by anevilyak, 8 years ago

Please provide either a photo or serial capture of the KDL. Also, do all CDs trigger this, or only particular ones?

comment:2 by ttcoder, 8 years ago

Cc: degea@… added

by shaka, 8 years ago

Attachment: screenshot1.jpeg added

Screenshot of CD showing different name than Tracker

comment:3 by shaka, 8 years ago

It may have had to do with virtual memory as the kdl was a vm_pagefault. Also, I'm working on real hardware with hard drives that have been used for many years. After posting, there were other (seemingly) unrelated kdl's. * Could someone direct me in setting up serial port output from KDL land? I spend many hours giving Haiku a workout ;-) and want to help.

comment:4 by humdinger, 8 years ago

You need to connect another computer serially via null modem cable and start a serial terminal there with a 115200, 8n1 connection. While booting up Haiku hold SHIFT to enter the boot options and activate "Enable serial debug output" from the debug options. Continue booting and now capture Haiku's syslog with the other machine.

comment:5 by axeld, 8 years ago

A stack trace of the crash might or might not be helpful. If you are building your Haiku image yourself, it would be great if you can enable the guarded heap, and try again. If this is a possibility, and you need some pointers on how to set it up, please shout :-)

comment:6 by ttcoder, 6 years ago

Neophyte question..

Shouldn't cdda_write_fs_stat() call notify_entry_moved() (or maybe an equivalent function dedicated to notifying changes in volume names rather than plain file names) ?

The notification is made in the case of invididual track renamings in cdda_rename() here, http://cgit.haiku-os.org/haiku/tree/src/add-ons/kernel/file_systems/cdda/kernel_interface.cpp#n1816

but not for CD volume renaming in cdda_write_fs_stat() here.. http://cgit.haiku-os.org/haiku/tree/src/add-ons/kernel/file_systems/cdda/kernel_interface.cpp#n1542

Thought about asking that question since I remembered about this ticket (Tracker not being always notified of a CD volume name change).. Though I didn't witness it myself.. Is it normal to not notify volume name changes ?

EDIT: ok witnessed it just now in fact! I have a feeling the lack of name update occurs when a CD is inserted for the first time, and the volume name change occurs as a result of userland CDDB daemon renaming it: Tracker still displays the CD as "Audio CD" no matter what. However, next time you insert the CD its name will be fetched from the virtual "attributes" stored in home/config/settings/cdda/, and in that case the CD volume name will be displayed correctly.

EDIT2 (6 months later...): I had somehow overlooked that this lack of vfs notification can't be related to the cdda KDLs I track in other tickets, as those occur even on audio CDs that have already been inserted and looked up and had their name registered (i.e. they no longer undergo a vfs rename()). As to this ticket, no KDL photographs was ever provided, so not sure what anyone can make of it..

EDIT3 ok.. cdda_write_fs_stat() actually looks pretty normal when compared with e.g. its bfs counterpart.. So not sure what's going on there.

Last edited 5 years ago by ttcoder (previous) (diff)

comment:7 by ttcoder, 5 years ago

So that was an easy enough question to answer, once finding a bit of time to dig.. Turns out (based on e.g. BFS as a reference) that it is normal for xxx_write_fs_stat() to not send notifications, and there are no other notification hooks missing. So apparently renaming a volume works differently than renaming a file within that volume, insofar as notifications are concerned. So analyzing that part of cdda is a false lead, the lack of Tracker notification probably lies elsewhere.

Interesting though that the problem shows up even more with userland-fs (i.e. with userlandfs/cdda, Tracker remains stuck on the old volume name in every instance, instead of just once in a while).

Last edited 5 years ago by ttcoder (previous) (diff)

comment:8 by ttcoder, 5 years ago

hrev48946 might contribute to fixing this.. Some symptoms above are a bit different, but others are quite similar (KDL after Tracker interaction e.g.)..

comment:9 by waddlesplash, 4 years ago

Resolution: fixed
Status: newclosed

A lot of the other symptoms (e.g. CD not being looked up in CDDB) were probably fixed by me in hrev47476. Assuming fixed.

Note: See TracTickets for help on using tickets.