Opened 7 years ago

Closed 5 years ago

#8414 closed bug (fixed)

Terminal does not check desktop geometry

Reported by: arfonzo Owned by: pulkomandy
Priority: normal Milestone: R1
Component: Applications/Terminal Version: R1/Development
Keywords: Terminal geometry window-position Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

  1. Put the terminal window in your bottom right corner of the desktop, at 1920x1080.
  2. Quit the terminal.
  3. Change res to 800x600.
  4. Open terminal.

Now, terminal opens but is completely off screen. It appears not to do geometry checking, but just opens at its last known position whether it's on or off screen.

I believe that it should check the geometry to see if it's still within bounds, and if not, default to 0,0 or something similar.

Change History (9)

comment:1 Changed 7 years ago by arfonzo

I forgot to mention that I'm using hrev43882.

comment:2 Changed 7 years ago by diver

Looks like this could be related to this commit hrev38192.

comment:3 Changed 7 years ago by diver

Owner: changed from jackburton to pulkomandy
Status: newassigned

comment:4 Changed 7 years ago by Disreali

For this very reason, I find any app that saves its size and position by default to extremely annoying. StyledEdit also does that. It should be user set and not the default behaviour.

comment:5 Changed 7 years ago by jscipione

It's not just terminal, lots of apps have this fault. I'm afraid in order to fix it, windows are going to have to be moved into the available screen space when reducing resolution. I'm not sure what the best way to implement this so that it is not a jumbled mess of windows on top of each other.

comment:6 Changed 7 years ago by pulkomandy

I don't see how saving the size and position can be annoying ? The alternative is always opening at the same size and position, without any way for the user to change that default.

Of course, making it resolution-safe (or even better, resolution independant) is a good thing.

As far as I know, there is no perfect way to solve this problem. The closest match for Haiku is to save the window size&position as attribute in a document, so that it can be restored for that particular document (matching Tracker's spatial mode for folders). Pe does this, for example. But for apps that have no notion of a document, like terminal, I see no solution that matches ?

If you're single-window-mode people, then, I have no idea how it should work.

comment:7 in reply to:  5 ; Changed 7 years ago by axeld

Replying to jscipione:

It's not just terminal, lots of apps have this fault. I'm afraid in order to fix it, windows are going to have to be moved into the available screen space when reducing resolution. I'm not sure what the best way to implement this so that it is not a jumbled mess of windows on top of each other.

Since this isn't something you do on a daily basis, who cares if the windows are on top of each other in this situation?

comment:8 in reply to:  7 Changed 7 years ago by arfonzo

Replying to axeld:

Since this isn't something you do on a daily basis, who cares if the windows are on top of each other in this situation?

I do this on a daily basis. I think most virtualbox users do. One of the really great things about Haiku is I can flip the resolutions between full screen, and small-screen workspaces very quickly, for when I'm juggling multiple VMs, RDPs, and other sessions, this is a life saver.

I wouldn't mind some sane default to try to place it intelligently with the available geometry, or even at worst, all the top-lefts at 0,0.

comment:9 Changed 5 years ago by pulkomandy

Resolution: fixed
Status: assignedclosed

Fixed in hrev48271.

Note: See TracTickets for help on using tickets.