Opened 12 years ago
Closed 12 years ago
#8420 closed bug (fixed)
NetFS don't compile with DEBUG
| Reported by: | pdziepak | Owned by: | nobody |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | File Systems | Version: | R1/Development |
| Keywords: | gsoc2012 | Cc: | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Debug macros like PRINT, ERROR, etc. are defined differently in NetFS and UserlandFS. In NetFS they are called normally PRINT("this is a number %d", i) while in UserlandFS they require double brackets PRINT(("this is a number %d", i)). Unfortunately, somehow this got mixed up in NetFS and there are both styles of calling these macros what causes the incorrect one to produce compilation errors.
The patch makes NetFS definitions of these macros the same as UserlandFS (that implementation seems to be more up to date) and corrects all calls to use double brackets.
Attachments (2)
Change History (5)
by , 12 years ago
| Attachment: | netfs_debug.patch added |
|---|
comment:1 by , 12 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 12 years ago
by , 12 years ago
| Attachment: | 0001-Fix-8420-NetFS-does-not-compile-with-DEBUG.patch added |
|---|
comment:3 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Thanks a lot. Committed in hrev43970.
Note:
See TracTickets
for help on using tickets.
The single parentheses style is really preferred. So it would be nicer to switch everything to that style instead of the other way around.