Screen preflet crashes when opening

[DaaT]

Using hrev43901, whenever I try to open the screen preflet it simply crashes. I'm attaching a photo I took with the bt result.

[anevilyak]

There are two problems occurring here:

1) In the case of a fixed refresh rate, the way in which the resolution string is formatted is inconsistent with the way it's generated when searching for it in _UpdateRefreshControl(). This results in us potentially failing to find that item if the refresh rate is not an even integral one, and leads to:

2) The handling of the "Other" refresh rate item needs to be reworked. In the above fixed refresh case, this item is not constructed at all, and the member pointer for it is left uninitialized.

Will deal with this over the weekend unless someone wants to beat me to it.

[umccullough]

Coverity also reports a few CIDs for the screen preferences (for those with access to view them):

• 9055 : ​http://scan.coverity.com:9065/cov.cgi?cid=9055
• 9965 : ​http://scan.coverity.com:9065/cov.cgi?cid=9965
• 10218 : ​http://scan.coverity.com:9065/cov.cgi?cid=10218

[anevilyak]

Should be fixed in hrev43907.

[anevilyak]

Fixed another problem in hrev43923.