Opened 7 years ago

Closed 7 years ago

#8443 closed bug (fixed)

Revision short cuts somewhat broken

Reported by: axeld Owned by: haiku-web
Priority: normal Milestone:
Component: Website/Trac Version:
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

The revision shortcuts don't work anymore consistently (hrev43906 does not work, while hrev43906 does). Older ones work, like hrev10000.

Since both will end up in the git code viewer, I fail to see why it doesn't work.

Change History (2)

comment:1 by umccullough, 7 years ago

I'm guessing it was intentionally chosen to end using the "r" syntax because buildtools and haiku repo's are now incremented independently (in fact, one might argue that it's appropriate to redirect the old "r" links to the old svn repo where they were combined still).

It was chosen to use hrev and btrev to indicate the separate repos.

Personally, I would like to start using the [e1b41a1a8c351233bcc6b98b6aa53a085351cf25] syntax (or the short tag option), but it seems we haven't included the Trac git module yet.

In most other trac repo's, square brackets are used to indicate a revision/commit/tag/label from the VCS.

comment:2 by nielx, 7 years ago

Resolution: fixed
Status: newclosed

This was not a conscious decision, but a configuration error. We have a link rewriter that rewrites the links into hrev links, like you will see now. However, that behaviour was overridden by the subversion repository module of Trac. Now it will work correctly.

Please reopen if the bug remains.

Note: See TracTickets for help on using tickets.