Opened 7 years ago

Closed 16 months ago

#8444 closed enhancement (fixed)

x86: add cpuid feature 6 flags

Reported by: yongcong Owned by: nobody
Priority: normal Milestone: R1
Component: System/Kernel Version: R1/Development
Keywords: gsoc2012 Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description (last modified by umccullough)

Add "Digital Thermal Sensor and Power Management Parameters" function 06H flags detection. ARAT and ENERGY_PERF_BIAS features are important for Operating Systems

Attachments (3)

0001-x86-add-cpuid-feature-6-flags.patch (4.6 KB) - added by yongcong 7 years ago.
0001-x86-add-cpuid-feature-6-flags.2.patch (4.6 KB) - added by yongcong 7 years ago.
syslog (344.0 KB) - added by SeanCollins 7 years ago.

Download all attachments as: .zip

Change History (18)

Changed 7 years ago by yongcong

comment:1 Changed 7 years ago by yongcong

Has a Patch: set

comment:2 Changed 7 years ago by tqh

To me the patch looks ok and done the right way. The ticket could have a better description though, like you do in #8445.

comment:3 Changed 7 years ago by yongcong

Add "Digital Thermal Sensor and Power Management Parameters" function 06H flags detection. ARAT and ENERGY_PERF_BIAS features are important for Operating Systems

comment:4 Changed 7 years ago by yongcong

oh, it seems that I can't change the description?

comment:5 Changed 7 years ago by umccullough

Description: modified (diff)

Fix description.

comment:6 Changed 7 years ago by yongcong

thanks umccullough

comment:7 Changed 7 years ago by SeanCollins

please fix the patch, it fials on 4 or 6 hunks. I will retest but is this Ia32 only or will this adress all x86 cpus ?

Changed 7 years ago by yongcong

comment:8 Changed 7 years ago by yongcong

rebase and resend the patch. The new patch can be applied to the latest master branch. Thank SeanCollins very much ;)

As the your question, FWICT, it address all x86 cpus at least those cpus from intel and amd

Changed 7 years ago by SeanCollins

Attachment: syslog added

comment:9 Changed 7 years ago by SeanCollins

2nd boot is with this patch applied, no negative changes in system behavior noted, If you need any additional testing dones on patchs like this please let me know.

comment:10 Changed 7 years ago by diver

Version: R1/alpha3R1/Development

comment:11 Changed 7 years ago by tqh

Patch applied in hrev44064. The FEATURE_6 names in the define could probably be more descriptive so maybe that should be changed.

comment:12 Changed 7 years ago by tqh

Has a Patch: unset

comment:13 Changed 7 years ago by mmadia

Is there any reason to keep this ticket open?

comment:14 Changed 2 years ago by axeld

Owner: changed from axeld to nobody
Status: newassigned

comment:15 Changed 16 months ago by korli

Resolution: fixed
Status: assignedclosed

Probably safe to close.

Note: See TracTickets for help on using tickets.