Opened 7 years ago

Closed 4 years ago

#8469 closed bug (duplicate)

Notification preferences not honored after reboot

Reported by: jprostko Owned by: pulkomandy
Priority: normal Milestone: R1
Component: Servers/notification_server Version: R1/Development
Keywords: notifications Cc:
Blocked By: #9425 Blocking: #8584, #11382
Has a Patch: yes Platform: All

Description

I noticed that disabling notifications via Preferences -> Notifications -> Disable notifications does not work as expected. I expect the disabling of notifications to survive a reboot, but it does not. Upon rebooting I see the NetworkStatus notifications (which shouldn't show), and the settings under Notifications are reset back to their original values which basically ensures that event notifications will occur against my desired behavior until I disable them again.

The latest Haiku revision I have tried is hrev44018, as of this writing.

Attachments (1)

0001-Fix-8469.-Notifications-server-start-only-if-enabled.patch (993 bytes) - added by Janus 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by anevilyak

Cc: anevilyak removed
Component: PreferencesServers/notification_server
Owner: changed from nobody to pulkomandy

comment:2 Changed 7 years ago by diver

Blocking: 8584 added

comment:3 Changed 6 years ago by Janus

Has a Patch: set

comment:4 Changed 6 years ago by mmadia

Just some information, hrev37700 added notifications_server to the Bootscript.

Janus's patch would technically work. However, in order to get notifications_server to boot on the first boot build/jam/HaikuImage* would need to add the notification_server symlink in ~/config/boot/launch. Given that it isn't an ideal solution, I'm hesitant to commit it.

#9425 has been created to address these issues.

comment:5 Changed 6 years ago by Janus

I agree with mmadia. I attached the patch only to point out the problem in Bootscript.

If you add the symlink you must enable the checkbox in the Notifications app. (ATM the checkbox "Enable notifications at startup" isn't set as default).

#9425 is a better solution, there is one downside the server is loaded on any boot.

Last edited 6 years ago by Janus (previous) (diff)

comment:6 Changed 6 years ago by leavengood

That downside isn't huge since if the start-up code is written like the mail_daemon's the notification_server would almost immediately quit if it was disabled in its settings.

comment:7 Changed 4 years ago by diver

Blocking: 11382 added

comment:8 Changed 4 years ago by pulkomandy

Blocked By: 9425 added
Resolution: duplicate
Status: newclosed
Note: See TracTickets for help on using tickets.