Opened 7 years ago

Closed 15 months ago

#8504 closed enhancement (fixed)

Delay redrawing icons until mouse release

Reported by: mmadia Owned by: jscipione
Priority: normal Milestone: R1
Component: Preferences/Deskbar Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

hrev44078

In Deskbar's preferences, quickly dragging the icon size from one extreme to the other will result in a noticable delay. It seems that while moving the slider, Deskbar will redraw for each increment, as opposed to the final position.

Perhaps triggering the redraw upon a mouse button release would be better?

Change History (8)

comment:1 by jscipione, 7 years ago

Perhaps triggering the redraw upon a mouse button release would be better?

No, that wouldn't be better. What would be better is if redrawing in Deskbar was faster.

Open an icon in DiskProbe and resize to see how resizing should perform. To do this in Deskbar is going to take a bit of refactoring but there is no reason that resizing icons in Deskbar can not be just as fast as in DiskProbe.

comment:2 by mmadia, 7 years ago

True, the redrawing of the icon (and vertical repositioning of the slider bar) is quite fast in DiskProbe.

However, I'm concerned that the additonal gui elements of Deskbar (along with the need to resize all icons of currently listed application, as opposed to just one) will make it more difficult to achieve the same redraw speed.

comment:3 by jscipione, 6 years ago

Status: newin-progress

comment:4 by jscipione, 6 years ago

Implemented icon caching in hrev45422 which speeds up Deskbar icon resizing although there is still a delay if you have a bunch of apps open.

comment:5 by jscipione, 6 years ago

Also hrev45401 should also help alleviate this problem as the application menu bar is no longer destroyed and rebuilt each time the icon size changes.

comment:6 by jscipione, 5 years ago

hrev48817 Should speed this up even more. If this is still not fast enough then I'm afraid we will have to update Deskbar to perform as described in this ticket. It would be a shame to give up the live updating. Is in necessary still?

comment:7 by jscipione, 15 months ago

I'm not sure what changed between hrev48817 and now but resizing Deskbar app icons has become buttery smooth even with a dozen apps open. Can we close this ticket?

comment:8 by diver, 15 months ago

Resolution: fixed
Status: in-progressclosed

I also has this, just checked and it's smooth even in VM. Closing as fixed.

Note: See TracTickets for help on using tickets.