Opened 7 years ago

Closed 7 years ago

#8519 closed enhancement (fixed)

Expander should have option to create directories that don't exist.

Reported by: kallisti5 Owned by: korli
Priority: normal Milestone: R1
Component: Applications/Expander Version: R1/Development
Keywords: Cc: przemub@…
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

  • Provide Expander a path to expand to that doesn't exist
  • Press extract.. Expander says "Destination folder doesn't exist"
  • A more useful feature may be to ask the user:
    "Destination folder doesn't exist, create?"
    <Yes> <No>
    

Attachments (3)

gci2012-expander-patch-8519.diff (2.1 KB) - added by mr.Noisy 7 years ago.
A patch from Przemysław Buczkowski (GCI 2012)
commit-64eda3e.diff (1.9 KB) - added by przemub 7 years ago.
A patch from Przemysław Buczkowski (GCI 2012) (corrected) (corrected)
patch.diff (1.6 KB) - added by mr.Noisy 7 years ago.
Final patch with few codestyle fixes

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by X512

Some archives store only one folder and Expander handle it correctly, but some other store files and folders directly in archive. This archives should be extracted in separate folder(usually named as archive but without file extension).

Extra checkbox "Extract in separate folder" can be added.

comment:2 Changed 7 years ago by scottmc

Milestone: R1/alpha4Unscheduled

This is feature creep and should not be in the alpha4 milestone. Moving to unscheduled.

comment:3 Changed 7 years ago by przemub

Cc: przemub@… added

Changed 7 years ago by mr.Noisy

A patch from Przemysław Buczkowski (GCI 2012)

comment:4 Changed 7 years ago by mr.Noisy

Has a Patch: set

comment:5 Changed 7 years ago by diver

Milestone: UnscheduledR1

comment:6 Changed 7 years ago by siarzhuk

Looks like this patch need some love - in case there are some nested nonexisted folders - data will be extracted in wrong folder. :-( For example: set the destination to /boot/home/desktop/uu/uu and start expanding - folders are created but files were extracted to Desktop instead of uu/uu folder.

comment:7 Changed 7 years ago by przemub

Replying to siarzhuk:

Looks like this patch need some love - in case there are some nested nonexisted folders - data will be extracted in wrong folder. :-( For example: set the destination to /boot/home/desktop/uu/uu and start expanding - folders are created but files were extracted to Desktop instead of uu/uu folder.

Indeed. :/ I'll find a workaround in a moment...

Last edited 7 years ago by przemub (previous) (diff)

Changed 7 years ago by przemub

Attachment: commit-64eda3e.diff added

A patch from Przemysław Buczkowski (GCI 2012) (corrected) (corrected)

comment:8 Changed 7 years ago by przemub

I found - it was necessary to create new BEntry after creating a directory path.

Changed 7 years ago by mr.Noisy

Attachment: patch.diff added

Final patch with few codestyle fixes

comment:9 Changed 7 years ago by siarzhuk

Resolution: fixed
Status: newclosed

Applied in hrev44946. thanks!

Note: See TracTickets for help on using tickets.