Opened 6 years ago

Closed 12 days ago

#8618 closed enhancement (fixed)

Make color in appearance preflet dragable

Reported by: mks Owned by: jscipione
Priority: normal Milestone: R1
Component: Preferences/Appearance Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

I am attaching a patch that makes the color well in the appearance preference application draggable.

  • Code is completely copied from Icon-O-Matic
  • I didn't want to mess with the existing coding style, so I tried to make it consistent with what's already there

I initially intended to make this so you could drag the color of one attribute to another (e.g. for copying the 'Window tab' color to 'Window border'), but then noticed that dropping a color on the dialog doesn't work that way. Perhaps this patch is useful anyways.

Attachments (1)

dragable-colorwell.patch (4.5 KB) - added by mks 6 years ago.

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by mks

Attachment: dragable-colorwell.patch added

comment:1 Changed 6 years ago by mks

Has a Patch: set

comment:2 Changed 6 years ago by mks

As there seems to be no interest in this, you might as well close the ticket. Any kind of answer would've been great though. Way to go to attract developers!

comment:3 Changed 6 years ago by axeld

Sorry mks, it's just obviously a very busy time for everyone.

I'm not sure why you think that dropping a color into the list does not work - at least it could be made to work, even if the Icon-O-Matic code does not support this. And this is a feature that probably should be implemented indeed, to make this patch really useful.

Other than that, the patch looks good for the most part. Is there any reason you put point_to_point_distance() into the header? Also, I would make make_color_drop_message() static (and it should then also be moved to the top of the file, together with point_to_point_distance().

comment:4 Changed 2 years ago by pulkomandy

Owner: changed from darkwyrm to jscipione
Status: newassigned

I think jscipione just reimplemented this?

comment:5 Changed 2 years ago by diver

Almost, but without dropping a color into the list which would be very useful.

comment:6 Changed 2 years ago by jscipione

I guess I did reimplement this feature. Icon-O-Matic code generally comes from Colors! so that is why the code is similar. I made a few improvements and also made the coding style match. You can both drag a color onto the preview and also drag from it. Would there be interesting in dragging onto the color blocks on the list as well?

comment:7 Changed 2 years ago by jscipione

Resolution: fixed
Status: assignedclosed

Fixed in hrev50472 and then also added drag and drop between list items in hrev50495

comment:8 Changed 2 years ago by vidrep

Devs, note comment 2: "As there seems to be no interest in this, you might as well close the ticket. Any kind of answer would've been great though. Way to go to attract developers!" This is exactly the kind of thing I was referring to on IRC today. How many potential contributors have we lost due to lack of response from the devs within a reasonable time frame?

comment:9 Changed 2 years ago by diver

I was kinda expecting to be able to drag'n'drop colorwell to list items :)

comment:10 Changed 22 months ago by jscipione

Resolution: fixed
Status: closedreopened

Partially reverted in hrev50574

Will try again with drag and drop between color preview and list items and also between list items

comment:11 Changed 12 days ago by jscipione

Resolution: fixed
Status: reopenedclosed

Finished enhancement by implementing drag and drop between list items in hrev52090

Note: See TracTickets for help on using tickets.