Opened 7 years ago

Closed 7 years ago

#8659 closed bug (fixed)

[Media] resizing it shouldn't resize MediaListItem view (easy)

Reported by: diver Owned by: anevilyak
Priority: normal Milestone: R1
Component: Preferences/Media Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #8665
Has a Patch: yes Platform: All

Description (last modified by yourpalal)

This is hrev44272

Possible ways to fix this:

  • decrease weight on list view / increase weight on content view
  • decrease max width on list view

Attachments (2)

media.png (17.2 KB ) - added by diver 7 years ago.
fixed-width.patch (948 bytes ) - added by humdinger 7 years ago.
Giving the scrollView a fixed size, setting explicit min-size.

Download all attachments as: .zip

Change History (8)

by diver, 7 years ago

Attachment: media.png added

comment:1 by yourpalal, 7 years ago

Description: modified (diff)
Summary: [Media] resizing it shouldn't resize MediaListItem view[Media] resizing it shouldn't resize MediaListItem view (easy)

comment:2 by humdinger, 7 years ago

Just assigning a weight of 0.0f to the scrollView looks like the easiest way. Though having no padding to the right of the list items feels a bit cramped. Is what I have done with SetExplicitMinSize() in the attached patch any good or is this not the way to handle this? Noob here. Opinions welcome.

by humdinger, 7 years ago

Attachment: fixed-width.patch added

Giving the scrollView a fixed size, setting explicit min-size.

comment:3 by humdinger, 7 years ago

Has a Patch: set

comment:4 by mmadia, 7 years ago

Blocking: 8665 added

comment:5 by yourpalal, 7 years ago

Hi Humdinger, thanks for working on this :)

I haven't tried applying/testing/compiling, but your changes look mostly good to me. Instead of using SetExplicitMinSize(), though, you should be able to just add some space for padding in MediaListItem::ItemWidth(). I'm pretty sure that that should have the same effect.

Again, thanks for looking into this!

comment:6 by humdinger, 7 years ago

Resolution: fixed
Status: newclosed

Thanks for that hint. Committed with hrev44278.

Hi Humdinger, thanks for working on this :)

Oh well... As a C++ dwarf I have to aim for the low hanging fruit. And at times even need a leg-up... :)
Thanks!

Note: See TracTickets for help on using tickets.