SoundPlay missing buttons

[Disreali]

Experienced on a fresh install of hrev44270.

I installed SpoundPlay-4.7.3 via its install script and when I started playing music it was missing it buttons. SoundPlay works fine, the button are just not visible.

On hrev43883, SpoundPlay's buttons were visible.

[dcatt]

This is still an issue with the most recent builds of Haiku (hrevr1alpha4-44577)!

[scottmc]

Can you try installing an older liblayout and see if they come back? ​http://www.haiku-files.org/files/optional-packages/liblayout-1.4.0-gcc2-2009-03-08.zip Let us know if this fixes it.

[dcatt]

Installed the older liblayout and the issue is still present.

[SeanCollins]

This should be a alpha4 blocker with Haiku being BeOS hrev5 compatible.

[czeidler]

could you test if hrev44039 causes it?

[jessicah]

Just testing from nightlies available, hrev44020 is fine, hrev44062 the buttons disappear (still clickable though). I will try to make a build for hrev44039 soon.

[jessicah]

Okies! hrev44039 has no visible buttons. Hope that helps! :)

[korli]

Has hrev44038 visible buttons? :)

[jessicah]

Yes, hrev44038 has visible buttons. Happy? :P

[scottmc]

So it seems something in hrev44039 broke this, perhaps it can be fixed soon?

[jscipione]

Soundplay expects the clipping constraints of the view to be ignored when drawing it's buttons. hrev44039 takes the view's clipping constraints into account in the following code:

// get the clipping constraints for the view
BRegion clipping;
view->GetClippingRegion(&clipping);

// intersect constraints with updateRect
BRegion updateClipping(updateRect);
clipping.IntersectWith(&updateClipping);

// clip to the intersection
view->ConstrainClippingRegion(&clipping);

Ignoring the clipping constraints of the view like in the following code fixes this bug but also breaks new code that assumes the the clipping constraints of the view will be honored.

// clip to updateRect
view->ConstrainClippingRegion(&updateRect);

Respecting the clipping constraints of the view seems like the more correct thing to do, but, since SoundPlay depends on the clipping constraints of the view being ignored when drawing it's buttons we need to also ignore them and then fix the code that depends on the clipping constrains of the view being set, most notably the code that draws the Return key in Keymap Preferences.

It is also a good idea to preserve the existing clipping constrains of the view by surrounding the button drawing code with PushState() and PopState() calls like this:

view->PushState()
...
view->PopState()

If nobody wants to tackle this I'll work on a fix shortly.

[jscipione]

I updated the button drawing code to preserve but not use the parent view's clipping constraints which fixes this bug but breaks the drawing of the return key in Keymap and then re-wrote the drawing code of the return key to work again in hrev44708.