Opened 12 years ago
Closed 12 years ago
#8776 closed bug (fixed)
[Text Search] Unable to find symbol < ' > in files where it does exist.
| Reported by: | x-ist | Owned by: | stippi |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Applications/TextSearch | Version: | R1/Development |
| Keywords: | Text Search | Cc: | |
| Blocked By: | Blocking: | ||
| Platform: | x86 |
Description
- Open Text Search in a source code directory like "<something>haiku/src/kits/tracker"
- Search for <AddShortcut> without braces. You'l see results like AddShortcut('Z')
- Now try to search <AddShortcut('>
- No results anymore
- Even if the text-string is copied from previously found files Text Search won't find it.
It seems Text Search does not like the <'> symbol.
Searching for < ' > symbol alone gives weird results too.
Attachments (1)
Change History (5)
comment:1 by , 12 years ago
| Component: | - General → Applications/TextSearch |
|---|---|
| Owner: | changed from to |
| Version: | R1/alpha3 → R1/Development |
comment:2 by , 12 years ago
The problem is that since the search pattern is wrapped into double quotes (like "pattern") the symbol <'> as part of the double quoted string must not be escaped. However it is escaped in Line 305 of Grepper.cpp. Removing that escaping solves the issue.
Maybe someone with commit rights could remove that escaping. It's not worth a patch, oh?
by , 12 years ago
| Attachment: | FixApostropheBug.patch added |
|---|
comment:3 by , 12 years ago
| patch: | 0 → 1 |
|---|
Well, here it is anyway. Would be nice if someone could commit it.
comment:4 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Looks harmless. Applied in hrev44490. Thanks!
Note:
See TracTickets
for help on using tickets.
Most likely an escaping issue when it invokes grep.