Opened 7 years ago

Closed 7 years ago

#8833 closed enhancement (fixed)

64-bit fixes for USB bus manager, ehci bus module, usb_disk and usb_hid

Reported by: anevilyak Owned by: mmlr
Priority: normal Milestone: R1
Component: Drivers/USB Version: R1/Development
Keywords: Cc: korli, xyzzy, siarzhuk
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Attached please find a patch which gets several of the USB modules compiling and AFAICT working on x86-64. Unfortunately I have no OHCI or UHCI controller hardware in this system so I can't easily validate changes there so I've left those out for the time being.

Before I commit, I'd like a review of it by those more in the know of the USB stack, since quite a few changes were involved.

Attachments (2)

usb.x86-64.patch (51.9 KB) - added by anevilyak 7 years ago.
usb_hid.patch (3.3 KB) - added by anevilyak 7 years ago.
Port usb_hid to x86-64

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by anevilyak

Attachment: usb.x86-64.patch added

comment:1 Changed 7 years ago by anevilyak

Has a Patch: set

comment:2 Changed 7 years ago by anevilyak

Type: bugenhancement

comment:3 Changed 7 years ago by xyzzy

Cc: xyzzy added

comment:4 Changed 7 years ago by siarzhuk

Cc: siarzhuk added

Changed 7 years ago by anevilyak

Attachment: usb_hid.patch added

Port usb_hid to x86-64

comment:5 Changed 7 years ago by anevilyak

Summary: 64-bit fixes for USB bus manager, ehci bus module and usb_disk64-bit fixes for USB bus manager, ehci bus module, usb_disk and usb_hid

comment:6 Changed 7 years ago by mmlr

Resolution: fixed
Status: newclosed

I've reviewed the OHCI part and it looks fine. I tested it in VirtualBox, where it seemed to require the use of MSIs to get working when emulating an IO-APIC based system (ICH9) without actual IO-APIC support (due to the lack of ACPI). Pulling in hrev44542 should get that part going. Feel free to add OHCI to the 64 bit image. I'm closing this as the patches have been applied in the x86_64 branch.

Note: See TracTickets for help on using tickets.