Opened 7 years ago

Closed 17 months ago

#8834 closed bug (fixed)

app_server remote/html5 won't work correctly on x86_64

Reported by: xyzzy Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Servers/app_server Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: x86-64

Description

The remote and HTML5 drawing engines in app_server currently use (uint32)this as some sort of token: http://cgit.haiku-os.org/haiku/tree/src/servers/app/drawing/remote/RemoteDrawingEngine.cpp#n25 and http://cgit.haiku-os.org/haiku/tree/src/servers/app/drawing/html5/HTML5DrawingEngine.cpp#n26

There are already comments saying that they need fixing for 64-bit. I don't have enough knowledge of how the code works to be able to fix it, so for now I'm just not going to compile in those backends on x86_64.

Change History (4)

comment:1 Changed 7 years ago by leavengood

This seems like the same sort of thing as the cookies in the input_server we have been discussing in the other ticket, so I don't think a pointer is really required either.

It seems like the server side could be changed and the RemoteDesktop client application would not need to be changed. But I'm just not sure how unique the tokens need to be and if they need to be unique between different Haiku machines (in other words, is something smarter that token++ needed.)

Some time ago I tested the remote app server and the concept of the HTML5 drawing engine is intriguing, so after the alpha 4 release I may try to get a testing environment set up for these and could see if changing to a more simple int ID format is possible.

comment:2 Changed 4 years ago by luroh

Milestone: R1Unscheduled

Moving non-x86 related tickets out of R1 milestone.

comment:3 Changed 2 years ago by axeld

Owner: changed from axeld to nobody
Status: newassigned

comment:4 Changed 17 months ago by waddlesplash

Resolution: fixed
Status: assignedclosed

RemoteDrawingEngine was fixed at some point, and HTML5DrawingEngine has now been removed. Closing.

Note: See TracTickets for help on using tickets.