Opened 7 years ago

Closed 2 years ago

#8887 closed enhancement (fixed)

[haiku_loader] adjust fail-safe video mode help text (easy)

Reported by: diver Owned by: nobody
Priority: normal Milestone: R1
Component: System/Boot Loader Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Adjust help text to mention that "Select fail-safe video mode" forces a resolution on an accelerated driver but if "Use fail-safe video mode" is selected it forces a resolution of vesa driver.

Attachments (3)

0001-haiku_loader-8887-haiku_loader-adjust-fail-safe-vide.patch (3.2 KB) - added by RahulAN 2 years ago.
Relabelled video mode to video driver
0001-Fixes-8887-Relabelling-BIOS-Fail-save-Menu-Items.patch (1.4 KB) - added by RahulAN 2 years ago.
V2 : changes as suggested by pulkomandy
0001-haiku-loader-Relabbeled-BIOS-Menu.patch (3.3 KB) - added by RahulAN 2 years ago.
Patch against source revision

Download all attachments as: .zip

Change History (15)

comment:1 Changed 5 years ago by pulkomandy

Summary: [haiku_loader] adjust fail-safe video mode help text[haiku_loader] adjust fail-safe video mode help text (easy)

comment:2 Changed 4 years ago by vasu014

I'd like to work on this.

comment:3 Changed 4 years ago by anevilyak

Owner: changed from anevilyak to nobody
Status: newassigned

comment:4 Changed 2 years ago by humdinger

As quickly discussed on IRC, the options should be renamed to be more clear. Proposal:

Use fail-safe video mode -> Use fail-safe graphics driver
Select fail-safe video mode -> Select screen resolution

("screen resolution" is less precise than "video mode", but more user friendly)

comment:5 Changed 2 years ago by vidrep

My preference would be to use "VESA graphics driver" instead of the generic terminology - It's more concise.

comment:6 Changed 2 years ago by pulkomandy

But VESA is only applicable when booting from BIOS, not UEFI, and not the other ports (ARM, ...). So if we do that, we would need to special-case it for each platform.

Changed 2 years ago by RahulAN

Relabelled video mode to video driver

comment:7 Changed 2 years ago by RahulAN

Has a Patch: set

comment:8 Changed 2 years ago by pulkomandy

As quickly discussed on IRC, the options should be renamed to be more clear. Proposal:

Use fail-safe video mode -> Use fail-safe graphics driver Select fail-safe video mode -> Select screen resolution

This is not what your patch does. So not only the confusion between the two menus remains, but now one of them is clearly mislabeled (there is no way to "select fail-safe video driver").

comment:9 Changed 2 years ago by RahulAN

Yes you are right . I will re write the patch as per above comments.

Changed 2 years ago by RahulAN

V2 : changes as suggested by pulkomandy

comment:10 Changed 2 years ago by axeld

It looks like you made the patch against your previous patch; you need to create a patch against the original version. The easiest way to achieve this would be to do the following:

$ git reset master

And then recreate your patch.

Changed 2 years ago by RahulAN

Patch against source revision

comment:11 in reply to:  10 Changed 2 years ago by RahulAN

Yes my mistake , I attached the patch against original version. :)

Replying to axeld:

It looks like you made the patch against your previous patch; you need to create a patch against the original version. The easiest way to achieve this would be to do the following:

$ git reset master

And then recreate your patch.

comment:12 Changed 2 years ago by pulkomandy

Resolution: fixed
Status: assignedclosed

Applied in hrev51179. Thanks!

Note: See TracTickets for help on using tickets.