Opened 12 years ago
Closed 8 years ago
#8887 closed enhancement (fixed)
[haiku_loader] adjust fail-safe video mode help text (easy)
Reported by: | diver | Owned by: | nobody |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | System/Boot Loader | Version: | R1/Development |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
Adjust help text to mention that "Select fail-safe video mode" forces a resolution on an accelerated driver but if "Use fail-safe video mode" is selected it forces a resolution of vesa driver.
Attachments (3)
Change History (15)
comment:1 by , 10 years ago
Summary: | [haiku_loader] adjust fail-safe video mode help text → [haiku_loader] adjust fail-safe video mode help text (easy) |
---|
comment:2 by , 10 years ago
comment:3 by , 10 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 8 years ago
As quickly discussed on IRC, the options should be renamed to be more clear. Proposal:
Use fail-safe video mode -> Use fail-safe graphics driver
Select fail-safe video mode -> Select screen resolution
("screen resolution" is less precise than "video mode", but more user friendly)
comment:5 by , 8 years ago
My preference would be to use "VESA graphics driver" instead of the generic terminology - It's more concise.
comment:6 by , 8 years ago
But VESA is only applicable when booting from BIOS, not UEFI, and not the other ports (ARM, ...). So if we do that, we would need to special-case it for each platform.
by , 8 years ago
Attachment: | 0001-haiku_loader-8887-haiku_loader-adjust-fail-safe-vide.patch added |
---|
Relabelled video mode to video driver
comment:7 by , 8 years ago
patch: | 0 → 1 |
---|
comment:8 by , 8 years ago
As quickly discussed on IRC, the options should be renamed to be more clear. Proposal:
Use fail-safe video mode -> Use fail-safe graphics driver Select fail-safe video mode -> Select screen resolution
This is not what your patch does. So not only the confusion between the two menus remains, but now one of them is clearly mislabeled (there is no way to "select fail-safe video driver").
by , 8 years ago
Attachment: | 0001-Fixes-8887-Relabelling-BIOS-Fail-save-Menu-Items.patch added |
---|
V2 : changes as suggested by pulkomandy
follow-up: 11 comment:10 by , 8 years ago
It looks like you made the patch against your previous patch; you need to create a patch against the original version. The easiest way to achieve this would be to do the following:
$ git reset master
And then recreate your patch.
by , 8 years ago
Attachment: | 0001-haiku-loader-Relabbeled-BIOS-Menu.patch added |
---|
Patch against source revision
comment:11 by , 8 years ago
Yes my mistake , I attached the patch against original version. :)
Replying to axeld:
It looks like you made the patch against your previous patch; you need to create a patch against the original version. The easiest way to achieve this would be to do the following:
$ git reset masterAnd then recreate your patch.
comment:12 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Applied in hrev51179. Thanks!
I'd like to work on this.