Opened 7 years ago

Closed 7 years ago

#9026 closed bug (fixed)

Disable folder name localization in Alpha 4

Reported by: pulkomandy Owned by: pulkomandy
Priority: blocker Milestone: R1/alpha4
Component: Kits/Locale Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

So, we have this bug: https://dev.haiku-os.org/ticket/8275

It is unlikely to be solved in time for Alpha 4. Moreover, changing the runtime_loader sounds like it could break other stuff, which wedon't want to risk.

Since this bug is rather annoying and has an easy workaround, I suggest applying the workaround as the default setting for Alpha 4. This way people will not be too annoyed by the bug, unless they turn the setting on.

Attachments (1)

0001-Disable-option-tab-folder-localization-option-for-R1.patch (1007 bytes ) - added by jscipione 7 years ago.
Patch that disables the Options tab in Locale and thus the folder name localization option

Download all attachments as: .zip

Change History (11)

comment:1 by leavengood, 7 years ago

Yeah I'm definitely not fixing #8275 for alpha4 and I doubt anyone else is.

I think this is a reasonable compromise. If you want to make this change directly in the alpha4 branch, feel free.

comment:2 by leavengood, 7 years ago

Resolution: fixed
Status: newclosed

The default is already for this to be off.

comment:3 by diver, 7 years ago

Resolution: fixed
Status: closedreopened

Actually the point of this ticket is to disable Options tab in the Locale preflet, so that user can't enable this option at all. cf. http://cgit.haiku-os.org/haiku/tree/src/preferences/locale/LocaleWindow.cpp#n247

comment:4 by leavengood, 7 years ago

Oh, I see. Given all the other bugs we recently fixed related to this, I don't think our international users would like having this option completely removed.

I think the best we can do for now is maybe a warning in this dialog that using this setting could result in occasional application deadlocks. In my experience having the deadlock happen was fairly rare.

comment:5 by diver, 7 years ago

From my experience there were quite a few users here in Trac, #haiku, jabber and qube.ru who complained about deadlocking apps because of this issue.

comment:6 by axeld, 7 years ago

While an alpha doesn't have to be perfect, I think the setting should either be removed, or left as is. I think an alert would be overkill (if just for the reason that this will have to be translated in a number of languages), and not really worth all the effort IMO.

comment:7 by scottmc, 7 years ago

This looks like it has a quick fix at least enough to be able to wrap up r1alpha4, so could one of you in the know please apply the fix and close this one out in the next day or so?

by jscipione, 7 years ago

Patch that disables the Options tab in Locale and thus the folder name localization option

comment:8 by kallisti5, 7 years ago

Priority: criticalblocker

will pick tonight

comment:9 by jscipione, 7 years ago

Has a Patch: set

comment:10 by kallisti5, 7 years ago

Resolution: fixed
Status: reopenedclosed

cherry-picked in hrevr1alpha4-44645 Thanks!

Note: See TracTickets for help on using tickets.