Opened 7 years ago

Closed 7 years ago

#9182 closed bug (fixed)

BDirectWindow::GetClippingRect : wrong behaviour

Reported by: jua Owned by: jackburton
Priority: normal Milestone: R1
Component: Kits/Game Kit Version: R1/Development
Keywords: BDirectWindow GetClippingRect Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

As discussed on the mailing list, the behaviour of BDirectWindow::GetClippingRect() is different than what is described in the BeBook. The BeBook says it must be called from within BDirectWindow::DirectConnected() and fails otherwise -- the current implementation does the exact opposite.

I've tested it by inverting the expression in the if-statement and it seems to work fine so far. Attaching a patch with the fix.

Attachments (1)

Fix-BDirectWindow-GetClippingRect.patch (749 bytes) - added by jua 7 years ago.
Fix which inverts the checking expression

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by jua

Fix which inverts the checking expression

comment:1 Changed 7 years ago by jua

Has a Patch: set

comment:2 Changed 7 years ago by korli

Resolution: fixed
Status: newclosed

Applied in hrev44858. Thanks

Note: See TracTickets for help on using tickets.