Opened 13 years ago

Closed 13 years ago

#920 closed bug (fixed)

Trac erroneously set the action to something else with each reload

Reported by: axeld Owned by: johndrinkwater
Priority: normal Milestone: Website R1
Component: Website/Trac Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Open a bug, hit reload, and the action will be changed - every time you reload, it will jump one option further. Pretty annoying when you change something else, and all of a sudden, you resolved or accepted a bug.

Attachments (2)

Haiku-from-rev1j-live.patch (878 bytes) - added by johndrinkwater 13 years ago.
Broken-mozilla.patch (735 bytes) - added by johndrinkwater 13 years ago.
Work-around (eugh) for Mozilla problem; apply to a clean rev1j

Download all attachments as: .zip

Change History (9)

comment:1 Changed 13 years ago by wkornewald

Cc: johndrinkwater added

This seems to be a bug in our componentselect code. It must be somewhere in updateSelection(). John, could you please have a look?

comment:2 Changed 13 years ago by wkornewald

Milestone: Haiku R1Website R1

comment:3 Changed 13 years ago by johndrinkwater

Just had a very quick look: could be the browser doesn't (but should) reset variables between reloads, a potential fix is posted below. Excuse me for not testing it; can not with the current Trac permissions.

Changed 13 years ago by johndrinkwater

Attachment: Haiku-from-rev1j-live.patch added

comment:4 Changed 13 years ago by wkornewald

Cc: johndrinkwater removed
Owner: changed from wkornewald to johndrinkwater

Unfortunately, this didn't fix it. I've added you to the developers group. Hopefully that helps.

comment:5 Changed 13 years ago by johndrinkwater

Cheers, i'll have a dig into it now.

comment:6 Changed 13 years ago by johndrinkwater

Status: newassigned

Figured this bug out: It only affects Mozilla & Firefox users :( Opera + Konq don't show signs of the bug. I didn't really believe it, but after lots of DOM digging, I had a good search of Bugzilla for any syptoms of this. To name a few, bugs 270071, 254129, 311507, and 175289.

Because of how componentselect works (it removes + adds components to the page) it enters one of those edge cases where the GRE doesn't do too well. I'll look into mooting the problem, if it can be done with a js hack :)

For a little testcase, try here: http://www.quirksmode.org/js/tests/moz_radios.html

(ticket intentionally accepted)

Changed 13 years ago by johndrinkwater

Attachment: Broken-mozilla.patch added

Work-around (eugh) for Mozilla problem; apply to a clean rev1j

comment:7 Changed 13 years ago by wkornewald

Resolution: fixed
Status: assignedclosed

Thanks for the patch. I hope Mozilla gets to fixing those bugs, finally.

Note: See TracTickets for help on using tickets.