Opened 11 years ago

Closed 11 years ago

#9247 closed bug (fixed)

Debugger skips a frame in some cases

Reported by: anevilyak Owned by: anevilyak
Priority: normal Milestone: R1
Component: Applications/Debugger Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

If a program crashes due to dereferencing a NULL function pointer, Debugger doesn't quite handle unwinding the top frame correctly. As a consequence it essentially winds up skipping the frame which actually caused the crash in question. Attached a simple patch to handle this for x86. Please review and let me know if it's incorrect, though it appears to work for my tests.

Attachments (1)

debugger_nullptr_crash.patch​ (2.3 KB ) - added by anevilyak 11 years ago.

Download all attachments as: .zip

Change History (5)

by anevilyak, 11 years ago

Attachment: debugger_nullptr_crash.patch​ added

comment:1 by anevilyak, 11 years ago

patch: 0 → 1

comment:2 by bonefish, 11 years ago

Looks OK, though a null pointer is just a special case. The effect is the same for any non-executable address. ATM readability can be checked at least.

comment:3 by anevilyak, 11 years ago

Owner: changed from bonefish to anevilyak
Status: new → in-progress

Good point. Thanks!

comment:4 by anevilyak, 11 years ago

Resolution: → fixed
Status: in-progress → closed

Modified version applied in hrev44938.

Note: See TracTickets for help on using tickets.