Opened 12 years ago
Last modified 4 years ago
#9389 assigned bug
[kernel] syslog_write omits carriage returns of KDL commands
| Reported by: | diver | Owned by: | nobody |
|---|---|---|---|
| Priority: | normal | Milestone: | R1.1 |
| Component: | System/Kernel | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Carriage returns (after entering KDL commands) do not end up in syslog after leaving KDL. KDL output to syslog was implemented in hrev35883.
Change History (3)
comment:1 by , 8 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 4 years ago
comment:3 by , 4 years ago
| Milestone: | R1 → R1.1 |
|---|
Note:
See TracTickets
for help on using tickets.
The problem is kputs and kputs_unfiltered go through the debug output filter and to syslog, but kputc doesn't.
The current approach isn't great because all control characters get into the syslog (for example if you use backspace, the backspace char is stored in syslog). The short term fix of modifying kputchar to also add the char to syslog will probably make this even worse (more control characters in syslog).
Ideally, the line editing should be done on screen/serial only, and the command added to the syslog only when it is complete. But we're probably not going to add a complete TTY layer to KDL.
Maybe we can replace a single kputchar('\n') with kputs("\n") to cover just this specific case and be happy enough with it?