Opened 6 years ago

Closed 6 years ago

#9422 closed bug (fixed)

drivesetup: SegFaults when adding a partition to intel or GPT

Reported by: jahaiku Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/DriveSetup Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Since the changes from tonight drivesetup SegFaults if you try to add a partition to intel or GPT. This is a gcc4 from hrev45227. Attached is the Stack-Trace.

Attachments (1)

DriveSetup-195-debug-02-02-2013-12-39-55.report (3.8 KB) - added by jahaiku 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by jahaiku

Summary: drivesetupdrivesetup: SegFaults when adding a partition to intel or GPT

comment:2 Changed 6 years ago by anevilyak

Owner: changed from stippi to axeld
Status: newassigned

comment:3 Changed 6 years ago by anevilyak

Version: R1/alpha4.1R1/Development

comment:4 Changed 6 years ago by anevilyak

The crash occurs because when CreateParametersPanel::AddControls() is called, _CreateViewControls() hasn't yet been called. Consequently it's calling CreateMenuBarLayoutItem() on an invalid pointer. Simply reordering things to call _CreateViewControls() first fixes the crash, but the resulting dialog doesn't look entirely correct.

comment:5 Changed 6 years ago by axeld

That's odd, I could have sworn I tested this. Thanks for the investigation, Rene!

comment:6 Changed 6 years ago by axeld

Status: assignedin-progress

comment:7 Changed 6 years ago by axeld

Resolution: fixed
Status: in-progressclosed

Fixed in hrev45232.

Note: See TracTickets for help on using tickets.