Opened 12 years ago
Closed 12 years ago
#9487 closed bug (fixed)
GIFLoad array subscript below array bounds
Reported by: | pdziepak | Owned by: | pdziepak |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Add-Ons/Translators/GIF | Version: | |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
Due to variable range propagation enabled GCC notices (incorrectly) that
newEntry[fOldCodeLength] = *fOldCode;
may be unsafe due to fOldCodeLength being a signed integer. When building under Haiku it results in a warning which is treated as an error.
Attachments (1)
Change History (7)
by , 12 years ago
Attachment: | 0001-Fix-9487-GIFLoad-array-subscript-below-array-bounds.patch added |
---|
comment:1 by , 12 years ago
patch: | 0 → 1 |
---|
comment:2 by , 12 years ago
comment:5 by , 12 years ago
Owner: | changed from | to
---|---|
Status: | new → in-progress |
Note:
See TracTickets
for help on using tickets.
To be honest I was a bit concerned about these copying loops but since I know nothing about GIF format and
memcpy()
is not an exact equivalent of them I decided to leave it as it is. It is out of scope of this patch anyway.