Opened 7 years ago

Closed 5 years ago

#9505 closed enhancement (fixed)

Playlist filetype doesn't use Playlist icon (easy)

Reported by: jstressman Owned by: stippi
Priority: normal Milestone: R1
Component: User Interface Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

I've saved playlists with MediaPlayer, but they only use the default file icon.

Is there a reason we're not using the Playlist icon for application/x-vnd.haiku-playlist ?

Perhaps because a music note isn't indicative of the possible video files that might be included in a playlist?

If we need a better icon, perhaps this can be made a task. Otherwise maybe we can at least use the existing Playlists icon so that playlists are easily recognizable without requiring a file extension to be added manually.

Attachments (2)

playlist3.png (90.6 KB ) - added by jstressman 7 years ago.
playlist files after adding the Playlist icon using FileTypes.
x-vnd.haiku-playlist (1.7 KB ) - added by kushalsingh007 5 years ago.
Adding the required file for mime_db

Download all attachments as: .zip

Change History (5)

by jstressman, 7 years ago

Attachment: playlist3.png added

playlist files after adding the Playlist icon using FileTypes.

comment:1 by pulkomandy, 5 years ago

Summary: Playlist filetype doesn't use Playlist iconPlaylist filetype doesn't use Playlist icon (easy)

The file type is missing from the MIME database and only registered when you save a playlist. We should probably add it there. The icon looks fine to me (it is in src/data/artwork)

comment:2 by kushalsingh007, 5 years ago

I will be working on this ticket.

by kushalsingh007, 5 years ago

Attachment: x-vnd.haiku-playlist added

Adding the required file for mime_db

comment:3 by pulkomandy, 5 years ago

Resolution: fixed
Status: newclosed

Added in hrev48781. Thanks! Even for simple changes like this it would be nice to wrap them in a git patch (using git format-patch). This makes sure you get proper credit for your changes, and also allows you to include a commit message describing the changes made.

Note: See TracTickets for help on using tickets.