[ActivityMonitor] Settings can't be opened if Always on top is enabled

[diver]

See hrev45344.

[dsjonny]

(This is the same in MediaPlayer.)

[korli]

Freeman, thanks for the patch. Here are my remarks:

• I'd just add a method IsAlwaysOnTop() in ActivityWindow.h instead of using a constructor parameter.
• fAlwaysOnTop is not a boolean but a pointer to a BMenuItem.
• method or function parameter names begin with a lowercase character.

[Freeman]

Do you mean to use the function as the parameter? Like new SettingWindow(this, _IsAlwaysOnTop());

[korli]

Replying to Freeman:

Do you mean to use the function as the parameter? Like new SettingWindow(this, _IsAlwaysOnTop());

No, I mean that IsAlwaysOnTop() can be called in the SettingsWindow constructor.

[Freeman]

Replying to korli:

Replying to Freeman:

Do you mean to use the function as the parameter? Like new SettingWindow(this, _IsAlwaysOnTop());

No, I mean that IsAlwaysOnTop() can be called in the SettingsWindow constructor.

How is the method in ActivityWindow going to be called by the constructor of SettingsWindow?

[korli]

Replying to Freeman:

How is the method in ActivityWindow going to be called by the constructor of SettingsWindow?

target->IsAlwaysOnTop()

[korli]

The build fails with this patch applied.

[Freeman]

Yeah I think I messed up my source by using reset --hard. Hold on I'll fix the code.

[korli]

Your patch includes an unneeded modification of the line 41/42 of ActivityWindow.h. Please fix. Also ActivityWindow::IsAlwaysOnTop() should be const.

[korli]

On a second thought, the feel shouldn't be changed if the ActivityWindow isn't always on top. Or do you have a good reason for that?

[Freeman]

So what should be done at this point?

[korli]

Edited and applied in hrev46476.

[diver]

Something is still not right.

• Settings->Settings
• Settings->Always on top

After that you can't open Settings window anymore.

[korli]

Fixed in hrev46477. Thanks for testing!

BTW having both a settings window and a settings menu for a simple app seems over the top.