Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9645 closed bug (duplicate)

Tracker: find window layout

Reported by: dsjonny Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1/Development
Keywords: Cc: starsseed@…
Blocked By: #8707 Blocking:
Has a Patch: no Platform: All

Description

This is not a "new" problem, but the localized find window in the Tracker has wrong layout when a string/control is larger:

And because of this problem we cannot make a proper translation too, because some strings a wider than the control. Using: 45464 nightly.

Attachments (1)

find.png (11.0 KB) - added by dsjonny 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by dsjonny

Attachment: find.png added

comment:1 Changed 6 years ago by axeld

If someone wants to tackle this, please bring aldeck's tracker layout branch up to date, and import that one instead :-)

See https://github.com/aldeck/haiku/tree/tracker_layout

comment:2 Changed 6 years ago by starsseed

Cc: starsseed@… added

comment:3 Changed 6 years ago by jscipione

Blocked By: 8707 added
Resolution: duplicate
Status: newclosed

Duplciate of #8707. Also, aldeck's tracker_layout branch does not include layout code for the Find window.

comment:4 Changed 6 years ago by axeld

Ah, great to know, thanks John! Last time I talked to Alexandre he mentioned that it would be pretty much complete, just need to get update to the latest tree revision. I thought that would imply the complete UI, but that was obviously an incorrect assumption.

Nonetheless, it would be great to import this.

comment:5 Changed 6 years ago by jscipione

A while back I converted the Find window to use the layout APIs but I ran into a problem. Clicking the expander would increase the window size but then clicking it again to un-expand the window wouldn't decrease the height again. However, I should bring that branch up again because I've run into this problem in Time prefs and a few other places now and I know how to fix it, I just need to add some glue in the right places.

Concerning aldeck's tracker_layout branch I may have made life difficult for him to merge his code when I did my style overhaul of Tracker. It provides a good opportunity to dust off the 3-way merge tool.

Note: See TracTickets for help on using tickets.