#984 closed bug (fixed)
Generic application icon in deskbar is old style 8 bit
| Reported by: | jackburton | Owned by: | jackburton |
|---|---|---|---|
| Priority: | low | Milestone: | R1 |
| Component: | Applications/Deskbar | Version: | R1/pre-alpha1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
The generic app icon in deskbar is the 8 bit non vector icon. See also bug #890
Change History (8)
follow-up: 2 comment:1 by , 16 years ago
comment:2 by , 16 years ago
Replying to aldeck:
Seems fixed here. Not sure it's the same issue but i can only see the old icon in ProcessController's menus, the "/bin/sh --login" item uses the old icon.
Nope, it's still there. Just compare the icon shown in deskbar with the icon shown by tracker for the generic application.
comment:3 by , 16 years ago
Seems the old style icon is only used when there is no icon for the application. This is caused by the following lines in BarApp.cpp: <pre> if (appMime.GetIcon(barInfo->icon, B_MINI_ICON) != B_OK) {
const BBitmap* generic = AppResSet()->FindBitmap(B_MESSAGE_TYPE, R_GenericAppIcon); if (generic)
barInfo->icon->SetBits(generic->Bits(), barInfo->icon->BitsLength(),
0, generic->ColorSpace());
}
</pre>
Basically if getting the icon for the application fails, it uses an icon stored in its resources.
follow-ups: 5 7 comment:4 by , 16 years ago
Ah, cool! Thanks for figuring it out. This could probably be fixed by simply using GetTrackerIcon() and no resources at all. This should then already fall back to the correct generic icon. The problem of the code is of course that if the design got changed, then this code would display the wrong icon regardless.
comment:5 by , 16 years ago
| Owner: | changed from to |
|---|
Replying to stippi:
Ah, cool! Thanks for figuring it out. This could probably be fixed by simply using GetTrackerIcon() and no resources at all. This should then already fall back to the correct generic icon.
Ok, I'll try that. Thanks for the hint!
The problem of the code is of course that if the design got changed, then this code would display the wrong icon regardless.
Yeah, indeed.
comment:7 by , 16 years ago
Replying to stippi:
Ah, cool! Thanks for figuring it out. This could probably be fixed by simply using GetTrackerIcon() and no resources at all. This should then already fall back to the correct generic icon. The problem of the code is of course that if the design got changed, then this code would display the wrong icon regardless.
BTW I now realized I could use GetTrackerIcon() instead of GetIcon() directly, right ?
Seems fixed here. Not sure it's the same issue but i can only see the old icon in ProcessController's menus, the "/bin/sh --login" item uses the old icon.