[ProcessController] kill dialog is not in the center of a screen

[diver]

if i remember correctly it used to be in the center before. Might be related to hrev45681.

[anevilyak]

The way it's positioned now is normal behavior for BAlert, it tries to position itself slightly offset from the window that spawned it, as best as allowed by proximity to the borders of the desktop. The above referenced commit doesn't change that, though it does change the size of the window slightly. In any case, PC didn't explicitly try to position itself either before or after said revision.

[pulkomandy]

ProcessController can't really decide where the alert is shown, because its size is computed only in BAlert::Go() which also shows it. So, calling CenterOnScren results in the alert having its top-left corner on the center of the screen.

BAlert::_Prepare detects that the alert has a set position and does not change it. But there is no way to compute the correct position before _Prepare is called.

There is also no way to specify which window is the parent. It just uses the current thread and tests if that's a window (otherwise it does center itself on screen instead).

So, it looks like some API improvement to BAlert could be needed here.