Opened 11 years ago

Closed 13 months ago

#10124 closed bug (fixed)

Disable "Edit name" item for read-only items

Reported by: humdinger Owned by: nobody
Priority: normal Milestone: R1/beta5
Component: Applications/Tracker Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

This hrev46250.

The menu item to rename a file/folder should be disabled when a read-only item is selected.

Change History (5)

comment:1 by phoudoin, 11 years ago

True, but somehow the end user should be notified why. A tooltip, an alert box, some "lock" icon, something. Otherwise one may think it's just broken.

comment:2 by humdinger, 11 years ago

Maybe the disabled menu item could read "Edit name (read-only)".
A tool-tip might work.
No alerts, please. :)

The lock-icon overlay might be a bit overkill. Seeing all files and folders of a CD-ROM or a read-only mounted volume with padlocks sounds noisy. I'd reserve those for PM-related read-onlyness (see #10122), if possible.

comment:3 by axeld, 11 years ago

It would be possible (and make some sense) to limit this to files that are read-only but reside on a writable disk. Maybe do that for folders only?

If our notifications were less ugly and large, one could also use them when someone tries to rename a file that cannot be renamed.

comment:4 by axeld, 8 years ago

Owner: changed from axeld to nobody
Status: newassigned

comment:5 by waddlesplash, 13 months ago

Milestone: R1R1/beta5
Resolution: fixed
Status: assignedclosed

"Edit name" is still possible to click but it only allows copying the name and not actually editing it (the text area is read-only) following jscipione's changes (most recently hrev57402.)

Note: See TracTickets for help on using tickets.