build_cross_tools_gcc4 doesn't like whitespaces in paths

[idefix]

Now that hrev46424 fixed ticket:10170, 'configure' outputs the following message:

jeroen@Gromit:~/Builds/Haiku/Raspberry Pi/haiku$ ./configure --build-cross-tools arm ../buildtools
/home/jeroen/Builds/Haiku/Raspberry Pi/haiku/build/scripts/build_cross_tools_gcc4: 49: [: /home/jeroen/Builds/Haiku/Raspberry: unexpected operator
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... arm-unknown-haiku

Attached patch​ is a crude attempt to fix this.

After applying this patch, 'configure' fails with the following message:

jeroen@Gromit:~/Builds/Haiku/Raspberry Pi/haiku$ ./configure --build-cross-tools arm ../buildtools
configure: error: path to source, /home/jeroen/Builds/Haiku/Raspberry Pi/buildtools/binutils, contains spaces

This comes from buildtools' ​configure (​configure.ac), so I think this cannot be fixed easily.

Maybe Haiku should also require the paths to be whitespace-less?

[idefix]

Crude patch to fix build_cross_tools_gcc4

[idefix]

Replying to idefix:

Now that hrev46424 fixed ticket:10170, 'configure' outputs the following message:

Of course, hrev46424 should be hrev46425...

[bonefish]

Thanks, patch applied in hrev46447. I don't think we want to mess with the binutils. If only the source path has to be free of spaces, putting the buildtools checkout to a respective location might work. I don't think there is any fundamental reason why Haiku's build system shouldn't be able to deal with spaces -- i.e. all remaining issues (if there are any) should be fixable.

[idefix]

It looks like the destination path also needs to be free of spaces:

mv -f .deps/merge.Tpo .deps/merge.Plo
/bin/bash ./libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I/home/jeroen/Builds/Haiku/buildtools/binutils/bfd -I. -I/home/jeroen/Builds/Haiku/buildtools/binutils/bfd -I/home/jeroen/Builds/Haiku/buildtools/binutils/bfd/../include  -DHAVE_bfd_elf32_littlearm_vec -DHAVE_bfd_elf32_bigarm_vec -DHAVE_bfd_elf32_little_generic_vec -DHAVE_bfd_elf32_big_generic_vec -DHAVE_i386pe_vec -DHAVE_i386pei_vec -DHAVE_bfd_elf32_i386_vec -DHAVE_x86_64pe_vec -DHAVE_x86_64pei_vec -DHAVE_bfd_elf64_x86_64_vec -DHAVE_bfd_elf64_l1om_vec -DHAVE_bfd_elf64_k1om_vec -DHAVE_bfd_elf64_little_generic_vec -DHAVE_bfd_elf64_big_generic_vec  -DBINDIR='"/home/jeroen/Builds/Haiku/Raspberry Pi/haiku/generated/cross-tools-arm/bin"'  -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -O2 -MT dwarf2.lo -MD -MP -MF .deps/dwarf2.Tpo -c -o dwarf2.lo -DDEBUGDIR=\"/home/jeroen/Builds/Haiku/Raspberry Pi/haiku/generated/cross-tools-arm/lib/debug\" /home/jeroen/Builds/Haiku/buildtools/binutils/bfd/dwarf2.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I/home/jeroen/Builds/Haiku/buildtools/binutils/bfd -I. -I/home/jeroen/Builds/Haiku/buildtools/binutils/bfd -I/home/jeroen/Builds/Haiku/buildtools/binutils/bfd/../include -DHAVE_bfd_elf32_littlearm_vec -DHAVE_bfd_elf32_bigarm_vec -DHAVE_bfd_elf32_little_generic_vec -DHAVE_bfd_elf32_big_generic_vec -DHAVE_i386pe_vec -DHAVE_i386pei_vec -DHAVE_bfd_elf32_i386_vec -DHAVE_x86_64pe_vec -DHAVE_x86_64pei_vec -DHAVE_bfd_elf64_x86_64_vec -DHAVE_bfd_elf64_l1om_vec -DHAVE_bfd_elf64_k1om_vec -DHAVE_bfd_elf64_little_generic_vec -DHAVE_bfd_elf64_big_generic_vec "-DBINDIR=\"/home/jeroen/Builds/Haiku/Raspberry Pi/haiku/generated/cross-tools-arm/bin\"" -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -O2 -MT dwarf2.lo -MD -MP -MF .deps/dwarf2.Tpo -c -DDEBUGDIR=\"/home/jeroen/Builds/Haiku/Raspberry Pi/haiku/generated/cross-tools-arm/lib/debug\" /home/jeroen/Builds/Haiku/buildtools/binutils/bfd/dwarf2.c -o dwarf2.o
gcc: error: Pi/haiku/generated/cross-tools-arm/lib/debug": No such file or directory
make[4]: *** [dwarf2.lo] Error 1
make[4]: Leaving directory `/home/jeroen/Builds/Haiku/Raspberry Pi/haiku/generated/cross-tools-arm-build/binutils/bfd'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/jeroen/Builds/Haiku/Raspberry Pi/haiku/generated/cross-tools-arm-build/binutils/bfd'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/jeroen/Builds/Haiku/Raspberry Pi/haiku/generated/cross-tools-arm-build/binutils/bfd'
make[1]: *** [all-bfd] Error 2
make[1]: Leaving directory `/home/jeroen/Builds/Haiku/Raspberry Pi/haiku/generated/cross-tools-arm-build/binutils'
make: *** [all] Error 2

Buildtools:	~/Builds/Haiku/buildtools
Haiku:	~/Builds/Haiku/Raspberry Pi/haiku

Attached is the complete buildlog​.