Opened 11 years ago
Closed 10 years ago
#10797 closed bug (fixed)
[HaikuDepot] crashed with no internet connection
| Reported by: | diver | Owned by: | stippi |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Applications/HaikuDepot | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
hrev47167, gcc2 hybrid.
After several hours of uptime network connectivity might get lost in vbox.
I only noticed it when I launched HaikuDepot and it crashed. Had two crashes with somewhat different backtraces.
Attachments (4)
Change History (12)
by , 11 years ago
| Attachment: | HaikuDepot-428201-debug-28-04-2014-11-10-13.report added |
|---|
by , 11 years ago
| Attachment: | HaikuDepot-428284-debug-28-04-2014-11-10-42.report added |
|---|
comment:1 by , 11 years ago
comment:2 by , 11 years ago
Reproducing this with libroot_debug would help locating the issue more precisely.
comment:3 by , 11 years ago
I personally saw KDLs in the net stack, just after HaikuDepot was started. No such crash with pkgman.
comment:4 by , 10 years ago
During offline testing of the install-wifi-firmwares script, I noticed this crash and found a simple way to reproduce it fairly reliably:
- Boot Haiku with either no network adapter attached, or the network cable unplugged
- Start HaikuDepot and select Tools --> Refresh depots
- Wait a while for HaikuDepot to crash (if it doesn't crash, try refreshing the depots again)
by , 10 years ago
| Attachment: | HaikuDepot-1150-debug-03-06-2014-13-28-59.report added |
|---|
LD_PRELOAD=/system/lib/libroot_debug.so HaikuDepot
by , 10 years ago
| Attachment: | HaikuDepot-1816-debug-03-06-2014-13-30-08.report added |
|---|
LD_PRELOAD=/system/lib/libroot_debug.so HaikuDepot
comment:5 by , 10 years ago
Thanks for the traces. Two different traces point at memory corruption. Both in the code which uses the HTTP network kit stuff.
follow-up: 7 comment:6 by , 10 years ago
After I reviewed the HTTP code and pointed out race conditions in the cookie and authentication code to pulkomandy, and after he fixed these, I have not had a single crash in HaikuDepot (not HTTP related or otherwise). Can this be closed?
comment:7 by , 10 years ago
comment:8 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I haven't tested HaikuDepot with no internet connection but if it crashes again we can always reopen it :)
I also saw these random crashes as soon as HaikuDepot started using the network HTTP classes. These seem to be just the same kind of crashes I see in WebPositive all the time (more frequently on a quad code machine, much less frequently on a dual core machine). My suspicion is that the HTTP stuff has a bug that corrupts memory. Most often, it crashes in some BString memory management code. It is also possible that there is a bug in BString which is triggered by specific behavior in the HTTP code, but if there was a problem in BString, one would think it got exposed more often.