ifconfig del KDLs reproducibly

[jackburton]

Doing an "ifconfig del /dev/net/<anydriver>/<anyinterface> KDLs horribly. I didn't post the KDL output because it's reproducible everytime. Will do if requested, though.

[anevilyak]

That doesn't seem like a good reason to omit the output. That makes the assumption that it isn't something about your configuration that makes it reliably reproducible, and further, if nothing else, it would be nice to save the person who winds up looking into it the time of having to reproduce it just to find out where to start looking.

[jackburton]

Indeed. Will take a picture next time, then.

[diver]

#7039/#7042 may be related.

[jackburton]

Yeah, the crash I got it's exactly the one in #7042, comment 1. Shall we mark this as duplicated of #7042 and change its summary ? (since you just have to delete the interface ONCE to trigger it).

[diver]

I think we should leave this one open since the back trace in #7042 is different from #7042 comment 1.

[jackburton]

KDL shot

[jackburton]

More information: I cannot reproduce it within VirtualBox. It's 100% reproducible on my laptop.

[diver]

Reproducible in vbox here with ipro1000 driver.

[jackburton]

Diver, could you try again ? Since I update my Haiku install lately, I cannot reproduce it anymore on real hardware, either.

[vidrep]

Hrev48254 gcc4 Running this command causes KDL: ifconfig del /dev/net/ipro1000/0 ; ifconfig /dev/net/ipro1000/0 up This is on real hardware. I'll attach a listdev and photo of KDL shortly. Would a serial debug log be useful?

[jackburton]

I still can't reproduce this, on a current revision, on VirtualBox. I can't test on real hardware anymore, though. Can you still reproduce it, diver ?

[diver]

I can still reproduce it in hrev49530 with VirtualBox 4.1.28 with NAT mode by running a few pings while deleting an interface.

[jackburton]

Interesting, I will try.

[jackburton]

Nope, still can't reproduce. It's either timing dependent, or... don't know.

[diver]

Try to start pinging or create some network activity in some other way and also while : ; do ifconfig del /dev/net/ipro1000/0 ; ifconfig /dev/net/ipro1000/0 up ; done

[waddlesplash]

The NetworkInterfaceTest in the test suite reproduces this also.

[jackburton]

I added a tentative fix in gerrit. Change 469. With "tentative" I just mean it needs to be reviewed to be sure it doesn't cause other problems. But it definitely fixes this problem.

[jackburton]

Axel, could you review the change ? Since you are one of the main contributors of this part of the code, I guess you can tell if it's okay or not.

[jackburton]

Applied in hrev52267