Opened 5 years ago

Closed 4 months ago

#11274 closed bug (fixed)

[WebPositive] crashes in WebCore::SocketStreamHandle::platformClose

Reported by: diver Owned by: pulkomandy
Priority: normal Milestone: R1
Component: Applications/WebPositive Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

hrev47897+ WebKit 1.4.4

To reproduce:

Attachments (2)

WebPositive-3519-debug-23-09-2014-08-33-53.report (50.3 KB) - added by diver 5 years ago.
WebPositive-338-debug-20-05-2015-20-13-40.report (27.9 KB) - added by xray7224 4 years ago.
irccloud debug file

Download all attachments as: .zip

Change History (5)

comment:1 Changed 4 years ago by xray7224

I believe I have managed to reproduce the bug by logging into https://irccloud.org (you can sign up for a free account). I have attached the bug report onto this.

Changed 4 years ago by xray7224

irccloud debug file

comment:2 Changed 4 years ago by pulkomandy

Yes, I already know that irccloud has the same problem. The easy/lazy fix would be to disable the Web Socket support in WebKit, and the better fix would be to review and simplify that code (too much threads used, and race conditions there).

https://github.com/haiku/webkit/blob/rebased/Source/WebCore/platform/network/haiku/SocketStreamHandleHaiku.cpp

Soup backend code for comparison: https://github.com/haiku/webkit/blob/rebased/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp

comment:3 Changed 4 months ago by waddlesplash

Resolution: fixed
Status: newclosed

Neither of those sites crash now (though WebSockets still don't work quite right, but that's tracked elsewhere.)

Note: See TracTickets for help on using tickets.