Opened 5 years ago

Closed 5 years ago

#11394 closed bug (fixed)

[PATCHes] BToolbar rework, standard icons, etc.

Reported by: waddlesplash Owned by: axeld
Priority: low Milestone: Unscheduled
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

(Don't close this ticket after applying patches, as I've got quite a bit that I'm posting here a few at a time so it's easier to review & revise them.)

Everything else should be pretty much self-explanatory.

Attachments (3)

Change History (12)

comment:1 by waddlesplash, 5 years ago

Has a Patch: set

comment:2 by jessicah, 5 years ago

Has a Patch: unset

Applied in hrev48216.

Last edited 5 years ago by jessicah (previous) (diff)

comment:3 by waddlesplash, 5 years ago

Has a Patch: set

comment:4 by jessicah, 5 years ago

Has a Patch: unset

Applied in hrev48269.

Last edited 5 years ago by jessicah (previous) (diff)

comment:5 by waddlesplash, 5 years ago

Has a Patch: set

comment:6 by jessicah, 5 years ago

I'm not completely confident reviewing this one. I'd rather see the likes of stippi or pulkomandy review.

However, a couple comments:

  1. don't you also need to address padding for this class?
  2. the doxygen documentation looks incorrect; it has BControl::SetIcon rather than BBitmap::SetIcon

comment:7 by waddlesplash, 5 years ago

Has a Patch: unset

comment:8 by waddlesplash, 5 years ago

Has a Patch: unset

On second thought, ignore that patch...

comment:9 by waddlesplash, 5 years ago

Has a Patch: unset
Resolution: fixed
Status: newclosed

BToolBar API is mostly OK at this point, so closing as resolved. (The only unapplied patch here should not be applied.)

Note: See TracTickets for help on using tickets.