[Terminal] Fonts not drawing properly when hinting is disabled

[KapiX]

When hinting is disabled, fonts are a bit wider but Terminal seems to be unaware of that (even if it is started with hinting already disabled).

I'm attaching two screenshots: 1) Hinting disabled

2) Hinting enabled

[jackburton]

(In #12093) Duplicate of #11478

[jackburton]

I think this is an app-server or interface kit bug, since also PE is affected by this. Just try to write a long line in PE and it'll show.

[jackburton]

Interestingly, this does not happen with the "Ubuntu mono" font, but it does with the "Noto" font.

[jackburton]

I think I found the problem(s):

I made TermView print the font width on start, and with hinting enabled, it's an integer. Without hinting, it's a decimal value. But TermView stores it into an int. Given that _DrawLinePart() also uses integers to draw the text, the longer the text line, the higher the error. Using a float for fFontWidth and in _DrawLinePart() fixes the problem. Now, though, there's a small problem with hinting enabled (look at the image on the right).

[jackburton]

Oh, of course, the latter problem is caused by the fact that I changed the hinting setting with Terminal already running, and it only calculates font width on start.

[jackburton]

I added change 821 on gerrit which fixes this ticket.

​https://review.haiku-os.org/c/haiku/+/821

[waddlesplash]

Change merged in hrev52707.

[nielx]

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone