Opened 8 years ago
Last modified 8 years ago
#12850 reopened bug
WebPositive loads also history if a ref is recived
| Reported by: | Paradoxon | Owned by: | pulkomandy |
|---|---|---|---|
| Priority: | normal | Milestone: | Unscheduled |
| Component: | Applications/WebPositive | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
If a ref or URL is handed over to WebPositive the whole save history is opend in a second window. Ist more common that a handed over URL or ref will just open only a window with the handed over link.
Attachments (2)
Change History (8)
by , 8 years ago
| Attachment: | 0001-WebPositive-dont-load-history-if-a-ref-is-recived.patch added |
|---|
comment:1 by , 8 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 8 years ago
comment:3 by , 8 years ago
the _RefsRecived wich is called at line 229
http://cgit.haiku-os.org/haiku/tree/src/apps/webpositive/BrowserApp.cpp#n229 it will count pagesCreated up if a ref is handed over: http://cgit.haiku-os.org/haiku/tree/src/apps/webpositive/BrowserApp.cpp#n469
So if a ref is handed over the whole history isnt loaded.
by , 8 years ago
| Attachment: | load_url_in_new_tab.patch added |
|---|
Loads URLS and refs wich are handed over to webpositive in a new tab so that the previous history is still alive ;-)
comment:5 by , 8 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Added a new Patch will loads new refs and so on as a new tab after the history was loaded
comment:6 by , 8 years ago
I'm still undecided on wether to merge this and bring the session back in that case. Maybe it should be an option or Web+ should offer a dialog asking what to do.
Or maybe we need a more powerful session management.
There are some style errors (missing space before {, trailing whitespace). Also, I don't understand how this works. The _RefsReceived case does not increment pagesCreated, so the new test for it being 0 is dead code (it will always be 0 at that point). Or did I misread something?