Opened 17 years ago
Closed 11 years ago
#1319 closed bug (no change required)
[Tracker] desktop icons selection is shifted 1px to the left
Reported by: | diver | Owned by: | axeld |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Kits/Interface Kit | Version: | R1/Development |
Keywords: | Cc: | aldeck, olive@… | |
Blocked By: | Blocking: | ||
Platform: | All |
Description
To see it open Magnify resize it a little bit and select Haiku volume on desktop. I will attach screenshot. Don't know ehich component to select for this bug, so please assign it.
Attachments (1)
Change History (17)
by , 17 years ago
comment:1 by , 17 years ago
Component: | - General → Kits/Interface Kit |
---|---|
Summary: | [Tracker] desktop icons selection is 1px to the left → [Tracker] desktop icons selection is shifted 1px to the left |
comment:2 by , 17 years ago
follow-up: 5 comment:4 by , 17 years ago
No it is shifted on R5, but not as much as on Haiku. I vote for changing whatever we need to change so it is indeed not shifted at all.
comment:5 by , 17 years ago
Replying to stippi:
No it is shifted on R5, but not as much as on Haiku. I vote for changing whatever we need to change so it is indeed not shifted at all.
Of course, I didn't mean: "if it's shifted on R5, let's keep it shifted", I was just looking for an hint for where to look: i.e. Tracker or our libbe :)
comment:6 by , 17 years ago
I suspect haiku renders the text 1 pixels off to the right in respect to how it's rendered on beos. Evidences:
- The problem described here
- this comment in BTextView::PointAt()
convert from text rect coordinates NOTE: I didn't understand why "- 1.0" and it works only correct without it on Haiku app_server. Feel free to enlighten me though! result.x += fTextRect.left; - 1.0;
- The fact that our Terminal on BeOS draws the text 1 pixel shifted to the left
comment:7 by , 16 years ago
Cc: | added |
---|
comment:8 by , 16 years ago
I had a look at this. Removing the + 1 in the following code:
BPoint loc; loc.y = textRect.bottom - view->FontInfo().descent; loc.x = textRect.left + 1;
in TextWidget.cpp, BTextWidget::Draw(), fixes the problem. But again, since the selection isn't as shifted in beos as it is on haiku, I think the problem could be more what I wrote in comment 6.
comment:9 by , 16 years ago
Cc: | added |
---|
comment:11 by , 15 years ago
Version: | R1/pre-alpha1 → R1/Development |
---|
comment:12 by , 14 years ago
Don't know if it helps but this does not happen when "List view" mode is chosen.
follow-up: 14 comment:13 by , 14 years ago
As it seems to be a bug in BTextView, maybe zooey could have a look? :-)
comment:14 by , 14 years ago
Replying to diver:
As it seems to be a bug in BTextView, maybe zooey could have a look? :-)
It's not. Tracker uses BTextView only in edit mode, not for just displaying the text.
comment:16 by , 11 years ago
Resolution: | → no change required |
---|---|
Status: | new → closed |
I've looked into it and this is now a won't-fix for me. See hrev46903.
How does it look on R5 ?