Opened 11 years ago

Last modified 21 months ago

#1326 assigned bug

Undo/Redo menu items are not properly enabled/disabled in Mail app

Reported by: ksmith Owned by: nobody
Priority: normal Milestone: R1
Component: Applications/Mail Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

When you launch the mail app, the redo menu item in the Edit menu is enabled. This should not be enabled. There is nothing to redo. The undo menu item is properly disabled at this point. Type a character in the message body. Undo is now enabled. Select undo, which will remove the character you typed. The undo option remains enabled, even though there is nothing else that can be undone. The undo option should become disabled when there is nothing remaining to be undone.

Change History (4)

comment:1 Changed 11 years ago by ksmith

After further investigation, this seems to be the result of how undo works in the BTextView, which uses a BUndoBuffer. The BUndoBuffer never resets its state to B_UNDO_UNAVAILABLE when the undo buffer is empty, which is why the Undo menu item becomes permanently enabled.

The Redo menu item is just enabled. There is no check for the availability of a Redo.

comment:2 in reply to:  1 ; Changed 11 years ago by jackburton

Replying to ksmith:

After further investigation, this seems to be the result of how undo works in the BTextView, which uses a BUndoBuffer. The BUndoBuffer never resets its state to B_UNDO_UNAVAILABLE when the undo buffer is empty, which is why the Undo menu item becomes permanently enabled.

The Redo menu item is just enabled. There is no check for the availability of a Redo.

Does this applies to R5 too ?

comment:3 in reply to:  2 Changed 11 years ago by ksmith

Replying to jackburton:

Does this applies to R5 too ?

Yes. This is the way undo works under R5 (at least in the BeMail app).

comment:4 Changed 21 months ago by axeld

Owner: changed from axeld to nobody
Status: newassigned
Note: See TracTickets for help on using tickets.